Add tests for scrooge_scala_library target type #366
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beala-stripe
changed the title
beala-stripe
changed the title
|
bazel-contrib/rules_scala#562 has landed and I've updated the SHA to point to it. |
|
Hello @beala-stripe, Is there any chance can you fix the branch conflicts. so i can share your PR for review. Thanks! |
sgowroji
added
lang: scala
gtech-bazel-bot
bot
added
the
awaiting-review
|
Hi there! Thank you for contributing to the IntelliJ repository. We appreciate your time and effort. We're doing a clean up of old PRs and will be closing this one since it seems to have stalled. Please feel free to reopen/let us know if you’re still interested in pursuing this or if you'd like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The
scrooge_scala_librarytarget type (part of the rules_scala project) recently experienced an IJ support regression. This PR adds a test which will catch this regression in the future. In short, the issue was that a new implementation of the scrooge_scala_library rule stopped returning output jars. This test checks the proper output jars are returned.The rules_scala project clones this repo and runs these tests as part of its test suite, so future regressions will be caught by this test.
This is WIP PR. It cannot land until this PR in rules_scala lands: bazel-contrib/rules_scala#562. At that point the rules_scala SHA in the WORKSPACE file can point at master (it's currently pointing at a branch with my fix).This is ready to land.
Testing
bazel test aspect/...passes