Provide support for duplicate paths #865
Closed
+107
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add feature as described in bazelbuild#832. RELNOTES: Automatic creation of parent directory specifications for paths with depth are prevented in pkg_tar archives.
Duplicate path entries are made possible within tar archives as discussed in feature request bazelbuild#849. This includes an interaction with create parents, where the only logical scenario which would require inference of a parent directory is when one does not already exist. This is because allowance of duplicates is only useful when explicit paths are declared. RELNOTES: Duplicate path entries supported within tar archives
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
aiuto
reviewed
May 1, 2024
I understand that. I am not so acquainted with the workflow yet. Let's discontinue this PR in favor of #850 which should now be in good shape. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outside of the discussion in the issue #849, there were some unforeseen interactions with create_parents. Otherwise the behavioral change should be what was discussed.
It is outside of the scope to order where the paths from deps or srcs are added to the archives, within a given instance of pkg_tar. It may be worth documenting that controlling the ordering of paths whether they originate from tars which are concatenated or files, requires a sequence of
pkg_tarinstances rather than relying on a single one. In a way undefined behavior may be expected when adding paths which conflict in the samepkg_tarinstance.