Skip to content

Make darwin a supported host platform #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hlopko opened this issue Jul 15, 2021 · 5 comments
Closed

Make darwin a supported host platform #837

hlopko opened this issue Jul 15, 2021 · 5 comments
Assignees

Comments

@hlopko
Copy link
Member

hlopko commented Jul 15, 2021

From #832 (comment)

image

@hlopko
Copy link
Member Author

hlopko commented Jul 15, 2021

CC @UebelAndre

@illicitonion
Copy link
Collaborator

Just to check - @hlopko, what is your proposed end-criteria for this issue? AFAICT the two things I've seen are:

  1. All of our tests run on the platform (which is true for macos except for one which is blocked on bazel 4.2.0)
  2. One of the maintainers is invested in keeping the above true

Does that sound about right? If so, are there any concrete blockers to this today?

@hlopko
Copy link
Member Author

hlopko commented Jul 19, 2021

For macos I'm not aware of any blockers. If you say you have the will and capacity to (from the top of my head, without any clear structure or anything, not even trying to be complete):

  • Make sure the rules are usable on the platform (for example
    • does debugging work on macos?
    • can you build Rust binary which has C++ library as a dependency?
    • can you create and use a Rust "framework"?
  • Figure out which Xcode versions you want to support
  • Keep an eye on macos specific issues, help debug/resolve them
  • Contribute macos expertise in design discussions

Then I'd just flip the bit and call it a supported platform. I'm less worried about supporting darwin than windows.

@illicitonion
Copy link
Collaborator

Yeah, I can sign up to that (assuming we're reasonably happy to decide most of these things as they come up, rather than proactively) :) Let's flip that bit!

@hlopko
Copy link
Member Author

hlopko commented Aug 10, 2021

SGTM! Will update the policy doc.

@hlopko hlopko closed this as completed Aug 10, 2021
hlopko added a commit to hlopko/rules_rust that referenced this issue Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants