Add a conditional implicit dependency on the import macro. #1151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlopko
reviewed
Feb 22, 2022
rust/private/utils.bzl
Outdated
| @@ -399,6 +399,21 @@ def transform_deps(deps): | |||
| cc_info = dep[CcInfo] if CcInfo in dep else None, | |||
| ) for dep in deps] | |||
|
|
|||
| def create_import_macro_dep(ctx): | |||
rust/private/transitions.bzl
Outdated
| def _with_import_macro_bootstrapping_mode_impl(ctx): | ||
| target = ctx.attr.target[0] | ||
| providers = [target[rust_common.crate_info], target[rust_common.dep_info]] | ||
| if hasattr(ctx, "executable") and hasattr(ctx.executable, "target"): |
There was a problem hiding this comment.
Could you remind me why is this necessary?
There was a problem hiding this comment.
Ack, this was a holdover from the previous attempt at this rule, which supported executable targets. No longer necessary since this is only used for lib targets.
cfredric
force-pushed
the
implicit_dep
branch
from
646d172 to
6c60048
Compare
hlopko
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #1008 and #1013. This PR aims to improve the UX of the import macro by not requiring every target to explicitly depend on the macro.
This PR adds an implicit attribute to every
rust_libraryandrust_binaryrule, which (if theuse_real_import_macroflag is enabled) adds theimportmacro crate to the target'sproc_macro_deps. If theuse_real_import_macroflag is disabled (which is the default), the implicit attribute points to a no-op shell script, and nothing is added to the target's dependencies.