Skip to content

Keep transitive linkargs when linking inline rust_test. #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mickeyh
Copy link

@mickeyh mickeyh commented Sep 29, 2022

I've locally confirmed that this fixes the issue I observed (for a single instance of this bug).

@google-cla
Copy link

google-cla bot commented Sep 29, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mickeyh
Copy link
Author

mickeyh commented Sep 29, 2022

Hmmm I prefer not to attach an email to my Github profile, so I cannot sign the CLA. Perhaps someone else can pick up this change (I would prefer if it can be upstreamed)

@scentini
Copy link
Collaborator

Hey @mickeyh, thanks for the contribution! The changes look good to me; I'd also like to see a test for this before approving.

Not signing the CLA however means that we can neither merge your PR, nor make use of your work when fixing the issue at hand, so I'm going to close it for now. I'll try go get to fixing the issue soon, if noone else volunteers.

@scentini scentini closed this Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants