Generate documentation with Skydoc. #28
Conversation
|
The CI failure is due to the fact that we are using tag 0.0.1 of rules_sass in skydoc, and we haven't cut a new release after the fix for adding cfg was checked in. Let's merge bazelbuild/rules_sass#7, cut a release, update skydoc to use the new version of rules_sass, cut a new release of skydoc, and update this PR. |
|
I merged the rules_sass one, feel free to ping again when this PR is ready
for review.
…On Thu, Feb 9, 2017 at 8:38 AM David Z. Chen ***@***.***> wrote:
The CI failure is due to the fact that we are using tag 0.0.1 of
rules_sass in skydoc, and we haven't cut a new release after the fix for
adding cfg was checked in.
Let's merge bazelbuild/rules_sass#7
<bazelbuild/rules_sass#7>, cut a release, update
skydoc to use the new version of rules_sass, cut a new release of skydoc,
and update this PR.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADjHf6qfMXpsx7-S6oUqoub_Qo0vcv0kks5rasJfgaJpZM4L7nbN>
.
|
davidzchen
force-pushed
the
skydoc
branch
2 times, most recently
from
e5b6700 to
90d7d52
Compare
|
Thanks, Damien. We still need a new release of skydoc with the recent fixes. The build is failing due to using an old version of protobuf. Sent bazelbuild/skydoc#41 |
|
Tests are passing. PTAL |
WORKSPACE
Outdated
| remote = "https://github.com/bazelbuild/skydoc.git", | ||
| tag = "0.1.2", | ||
| ) | ||
| load("@io_bazel_skydoc//skylark:skylark.bzl", "skydoc_repositories") |
There was a problem hiding this comment.
nit: space before load (also upper).
maybe pass buildifier on this file?
There was a problem hiding this comment.
Done. Ran buildifier.
| @@ -0,0 +1,201 @@ | |||
|
|
|||
There was a problem hiding this comment.
Shouldn't that file be only on the site branch? Or maybe only have the readme checked in that redirect to the website?
There was a problem hiding this comment.
You can publish from a directory in the master branch now. :)
https://help.github.com/articles/configuring-a-publishing-source-for-github-pages/
Fixes #12