Fix rustc_lib srcs glob and allow it to be empty. #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acmcarther
approved these changes
May 29, 2020
|
Updated the PR based on your comments |
|
Re-requested a review to ensure we are good to merge since I don't have write-access to the repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My team uses the
build --incompatible_disallow_empty_globflag in our .bazelrc. When usingrust_repositories(version = "nightly", iso_date = "2020-05-15")in our BUILD file, the build fails with the error:This glob is part of the rustc_lib filegroup. This PR adds allow_empty to that glob, similar to the change made in #245.