Handle debug info packages separately when using cc_common.link
#3257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debug info packages (`dSYM`, `pdb`) are created by `rustc` only if you link with `rustc`. When linking with `cc_common`, they should be handled by the cc toolchain or an custom aspect. Declaring them prematurely can cause conflicts.
yuzhy8701
changed the title
cc_common.linkcc_common.link
….link This replicates the behavior of the `cc_binary` rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug info packages (
dSYM,pdb) are created byrustconly if you link withrustc. When linking withcc_common, they should be handled by the cc toolchain or a custom aspect. Declaring them prematurely can cause conflicts.This PR removes the
dsym_folderdeclaration ifcc_common.linkis being used - since cc_common doesn't support dsym generation yet. It postpones the declaration ofpdb_fileafter checking with the cpp features first.