process_wrapper: Convert non-JSON diagnostics from LLVM to JSON. #3309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even when rustc is run with `--error-format=json`, LLVM may still [output human-readable diagnostics](https://github.com/llvm/llvm-project/blob/680391f07a45272bb9bfd385cf4c6846b8be32dd/llvm/lib/MC/MCSubtargetInfo.cpp#L82) that are not formatted as JSON. So far, process_wrapper has choked on these. This patch detects these lines and converts them to JSON so that they can be processed like JSON diagnostics from rustc itself. The correct fundamental fix would likely be to teach rustc itself to perform this conversion, but this is a change that would require some time to implement, so we're putting this fix in place instead.
martinboehme
force-pushed
the
process_wrapper
branch
from
74a208f to
6aa154e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even when rustc is run with
--error-format=json, LLVM may still outputhuman-readable diagnostics
that are not formatted as JSON. So far, process_wrapper has choked on these.
This patch detects these lines and converts them to JSON so that they can be
processed like JSON diagnostics from rustc itself.
The correct fundamental fix would likely be to teach rustc itself to perform
this conversion, but this is a change that would require some time to implement,
so we're putting this fix in place instead.