Skip to content

Implement priority support for extract_cargo_lints rule #3316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

havasd
Copy link
Contributor

@havasd havasd commented Mar 9, 2025

Clippy prioritizes the lint flags based on the order in the command line. This can be ordered by the priority field in the Cargo.toml file. More information: https://doc.rust-lang.org/cargo/reference/manifest.html#the-lints-section

Additionaly generate empty files when lints are not present in Cargo.toml file instead of throwing an error. This makes generation of such rules easier

FYI: @ParkMyCar

Clippy prioritizes the lint flags based on the order in the command line.
This can be ordered by the priority field in the Cargo.toml file.
More information: https://doc.rust-lang.org/cargo/reference/manifest.html#the-lints-section

Additionaly generate empty files when lints are not present in Cargo.toml file
instead of throwing an error. This makes generation of such rules easier
@ParkMyCar
Copy link
Contributor

Nice! Thanks @havasd!

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable! Thanks!

@illicitonion illicitonion added this pull request to the merge queue Mar 10, 2025
Merged via the queue into bazelbuild:main with commit 6e157dd Mar 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants