Skip to content

Export CcInfo for staticlib & cdylib allowing rust outputs to be used in c++ rules #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2020
Merged

Export CcInfo for staticlib & cdylib allowing rust outputs to be used in c++ rules #361

merged 1 commit into from
Jul 1, 2020

Conversation

GregBowyer
Copy link
Contributor

@GregBowyer GregBowyer commented Jun 30, 2020 •
edited
Loading

Its minor but since CcInfo now exists we can state staticlib to be a statlclib and cdylib to be the relevant .so

@GregBowyer GregBowyer force-pushed the ccinfo-outputs branch 2 times, most recently from 127aa4f to 35a53d6 Compare June 30, 2020 06:03
damienmg
damienmg approved these changes Jun 30, 2020
View reviewed changes
Copy link
Collaborator

@damienmg damienmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I just have a bunch of comment on the TODOs the code itself is a great improvement.

@GregBowyer GregBowyer mentioned this pull request Jun 30, 2020
Open
damienmg
damienmg reviewed Jun 30, 2020
View reviewed changes
@GregBowyer
Copy link
Contributor Author

Rebased to the latest and made more comment changes as per review

damienmg
damienmg approved these changes Jul 1, 2020
View reviewed changes
Copy link
Collaborator

@damienmg damienmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damienmg damienmg merged commit cf27a28 into bazelbuild:master Jul 1, 2020
@GregBowyer GregBowyer deleted the ccinfo-outputs branch July 1, 2020 16:11
@timothyklim timothyklim mentioned this pull request Jul 3, 2020
Closed
@PiotrSikora PiotrSikora mentioned this pull request Aug 3, 2020
Closed
@PiotrSikora
Copy link
Contributor

FYI, this broke the out_binary = True flag for Wasm introduced in #312. See: #386.

@bsilver8192 bsilver8192 mentioned this pull request Sep 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienmg damienmg damienmg approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GregBowyer @PiotrSikora @damienmg @googlebot