Add more solid and generic process wrapper #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelmansouri
changed the title
damienmg
reviewed
Jul 20, 2020
There was a problem hiding this comment.
Overall I don't see any blockers, however if you don't mind, could we add a bit more explanation to errors and let @epigramengineer test this one?
Co-authored-by: Damien Martin-Guillerez <[email protected]>
damienmg
approved these changes
Jul 21, 2020
There was a problem hiding this comment.
As it passes all the test, I am fine with this PR, I am going to wait another day for @epigramengineer to chime in on #375 before merging this one.
|
So tried from a clean Linux VM to make sure that everything in a minimalist project work. And it seems to be fine, not that it worked also without this PR. |
|
Ok we are one day later, so let's merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new process wrapper is in the process of being reviewed so it can be part of the skylib, in the meantime, some work have been invested in making it more solid, and some functionality like capturing the std output of the child process have been added.
This will allow us to use it to call rustfmt.