Skip to content

Conversation

@dzbarsky
Copy link
Contributor

Without this, we get errors like

          lld: error: unable to find library -lliblibcxx.static
          lld: error: unable to find library -lliblibcxxabi.static
          lld: error: unable to find library -lliblibunwind.static
          lld: error: unable to find library -llibmingw32
          lld: error: unable to find library -llibucrtbase

because get_lib_windows doesn't strip the leading lib.

non-msvc mode should use the same lib-naming conventions as non-windows.

Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I take it you have a mingw toolchain you're developing with? Can you check if there's a unit test for this that also needs to be updated? I feel like there is but don't remember where off hand.

; exit 1 \
; }
split_coverage_postprocessing_shell_commands: &split_coverage_postprocessing_shell_commands
- echo "9.0.0rc3" > .bazelversion
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to pin this here if possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revert this bit before landing; this was to debug the coverage duplicate actions that broke in bazel 8.5 and is another cause of red CI currently. bazelbuild/bazel#28056

@dzbarsky
Copy link
Contributor Author

Thanks! I take it you have a mingw toolchain you're developing with? Can you check if there's a unit test for this that also needs to be updated? I feel like there is but don't remember where off hand.

Yes we added hermetic mingw support to https://github.com/cerisier/toolchains_llvm_bootstrapped

I don't think there's a unit test for this, everything is green when run locally.

Tests can surely be added but given how many fixes I need to do here to get things functional, I don't know if I have cycles for adding all of them, they're a bit annoying to setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants