Skip to content

Traverse CrateGroupInfo when gathering CcInfo linking_context entries for use_cc_common_link #3787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ObsidianMinor wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −3
Open

Traverse CrateGroupInfo when gathering CcInfo linking_context entries for use_cc_common_link #3787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions rust/private/rustc.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1580,9 +1580,12 @@ def rustc_compile_action(
toolchain.stdlib_linkflags.linking_context,
]

for dep in crate_info.deps.to_list():
if dep.cc_info:
linking_contexts.append(dep.cc_info.linking_context)
linking_contexts += [
ddep.cc_info.linking_context
for dep in crate_info.deps.to_list()
for ddep in (dep.crate_group_info.dep_variant_infos.to_list() if dep.crate_group_info else [dep])
if ddep.cc_info
]

# In the cc_common.link action we need to pass the name of the final
# binary (output) relative to the package of this target.
Expand Down