-
Notifications
You must be signed in to change notification settings - Fork 471
Add test case for OUT_DIR in tests. #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I decided it's probably not worth it to emulate cargo here, after thinking about it some more. This patch should probably land for test coverage and documentation purposes. I searched the repo for |
I'm a bit confused, is the test supposed to fail with bazel at the moment? Because the CI seems to be green. Do we have a bug in the CI configuration? |
No--it all works, it's just undocumented (although implied by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it's a nice PR, thank you! To me it makes sense to check it in. Only one nit remaining.
This doesn't pass right now, but it does pass under
cargo test
. I see therustc
rule has a way to passOUT_DIR
, but it looks like tests aren't getting this right now. Posting this now, before I dig further, in case someone knows of a quick fix here.It looks like this cargo behavior is intentional: rust-lang/cargo#879