Support mobile/AJAX one-step authentication using a POST to the login callback. #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mobile clients use the platform SDK to authenticate, they can just send a resulting one-time-use token to the server for the server to use for authentication.
See https://developers.google.com/+/mobile/android/sign-in
This change allows mobile clients to POST to /login/google/callback with that code for a Google login experience.
I decided after some thought that it is OK that the "state" feature is not used in this case because the callback_uri is set to "postmessage" and Google will verify that this was the case when the token was issued. However, if this isn't the case an extra API might be needed for a mobile client to fetch a state and then submit it with the login request.