Skip to content

Suggested Layout change #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pietrop opened this issue Dec 14, 2018 · 8 comments
Closed

Suggested Layout change #50

pietrop opened this issue Dec 14, 2018 · 8 comments
Labels
CSS Something to do with styling Design Something to do with Design Enhancement a request for improvement

Comments

@pietrop
Copy link
Contributor

pietrop commented Dec 14, 2018

Just a suggestion on layout change to maximise space of text. Pending discussion. And low priority.

Current layout as of PR #46

controls

The thinking here is that there is a fair bit of space between the player controls and the transcript title, that is essentially due to the height of the video preview element. And it's taking up space that could be used to increase the height of the TimedTextEditor.

So the suggestion to be discussed, would be to move the video player next to the TimedTexEditor, and below the player controls. As well as the progress bar over the player controls. - see balsamiq sketch below.

controls layout change

On a 15 inch Mac this might not make much of a difference, but on smaller size laptops or tablets(?) this change could be a bit more significant.

@pietrop pietrop added CSS Something to do with styling Enhancement a request for improvement Design Something to do with Design labels Dec 14, 2018
@pietrop pietrop mentioned this issue Jan 4, 2019
4 tasks
@pietrop
Copy link
Contributor Author

pietrop commented Jan 17, 2019

Just to add to the mix of consideration, the current audio only combination looks a bit off

screen shot 2019-01-17 at 14 47 02

@ranaharoni
Copy link
Contributor

I think the current layout is great and all we have to do in order to (sort of) satisfy the second proposal is collapsing the controls on the top when "picture-in-picture" is active.

@pietrop
Copy link
Contributor Author

pietrop commented Jan 23, 2019

How would you collapse the controls when picture in picture is active?

You mean reduce in size or hide?

@ranaharoni
Copy link
Contributor

ranaharoni commented Jan 23, 2019

Reduce in size as pictured in this suggestion

@pietrop
Copy link
Contributor Author

pietrop commented Jan 23, 2019

ah, I see what you mean now.

@pietrop
Copy link
Contributor Author

pietrop commented Feb 2, 2019

done some more work on branch to explore this further #70

@pietrop
Copy link
Contributor Author

pietrop commented Mar 15, 2019

current PR for this is #111

@pietrop
Copy link
Contributor Author

pietrop commented Mar 18, 2019

addressed in #115

@pietrop pietrop closed this as completed Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Something to do with styling Design Something to do with Design Enhancement a request for improvement
Projects
None yet
Development

No branches or pull requests

2 participants