-
Notifications
You must be signed in to change notification settings - Fork 165
Suggested Layout change #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think the current layout is great and all we have to do in order to (sort of) satisfy the second proposal is collapsing the controls on the top when "picture-in-picture" is active. |
How would you collapse the controls when picture in picture is active? You mean reduce in size or hide? |
Reduce in size as pictured in this suggestion |
ah, I see what you mean now. |
done some more work on branch to explore this further #70 |
current PR for this is #111 |
addressed in #115 |
Just a suggestion on layout change to maximise space of text. Pending discussion. And low priority.
Current layout as of PR #46
The thinking here is that there is a fair bit of space between the player controls and the transcript title, that is essentially due to the height of the video preview element. And it's taking up space that could be used to increase the height of the TimedTextEditor.
So the suggestion to be discussed, would be to move the video player next to the TimedTexEditor, and below the player controls. As well as the progress bar over the player controls. - see balsamiq sketch below.
On a 15 inch Mac this might not make much of a difference, but on smaller size laptops or tablets(?) this change could be a bit more significant.
The text was updated successfully, but these errors were encountered: