Skip to content

Add punctuation changes - AWS Adapter #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Gribbs
Copy link

@Gribbs Gribbs commented Mar 18, 2019

Is your Pull Request request related to another issue in this repository ?
Yes, #110

Describe what the PR does
Appends punctuation items to the previous word on awstranscribe.

  • On the previous PR Stt adapter awstranscribe #110 a bug was discovered when double-clicking on a punctuation item. We decided the best way forward was to append punctuation to the previous item.

State whether the PR is ready for review or whether it needs extra work
Ready for merge

Additional context
Additional tests added

@Gribbs Gribbs mentioned this pull request Mar 18, 2019
@Gribbs Gribbs changed the base branch from master to stt-adapter-awstranscribe-review March 18, 2019 00:22
@Gribbs
Copy link
Author

Gribbs commented Mar 18, 2019

sorry just changed source branch from master to bbc:stt-adapter-awstranscribe-review

@pietrop
Copy link
Contributor

pietrop commented Mar 18, 2019

That's great, thanks, I'll have a proper look first thing tomorrow

@pietrop pietrop closed this Mar 18, 2019
@pietrop pietrop self-requested a review March 18, 2019 17:31
@pietrop pietrop changed the title Add punctuation changes Add punctuation changes - AWS Adapter Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants