-
Notifications
You must be signed in to change notification settings - Fork 165
move TimedTextEditor, TranscriptEditor and adapters util to packages #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move TimedTextEditor, TranscriptEditor and adapters util to packages #128
Conversation
also created stories, and package.json for each, but can't test them in storybook coz they have dependencies on adapters in Util folder
Got the storybook working! based on @chrishutchinson PR #122 There's still stuff to do, but as short lived spike, I think it be good to review it and merge it to the mono repo branch, before doing another spike with some more tweaks. so far done
Still to do, for another spike, PR
|
some quick lerna tips, that we should add to docs notes use
will ask for confirmation, and removes all the symlink and
lists all the modules it recognises in
links all the if that works, you should then be ready to do
should take you to http://localhost:6006 where you should see the storybook. unless any errors are flagged in the terminal. |
* Task: added lerna * WIP: storybook conversion * mend * WIP: adding MediaPlayer * move TimedTextEditor, TranscriptEditor and adapters util to packages (#128) * moved TimedTextEditor and TranscriptEditor to packages also created stories, and package.json for each, but can't test them in storybook coz they have dependencies on adapters in Util folder * moved Util and demdemo app * got storybook working * added demo app to storybook * mend * Fix: commenting out demo * Changed repo packages folder structure (#129) * cleaned up adapters * changed folder structure * fixed timecode converter duplice module * made all packages private except for TranscriptEditor * working * "Monorepo" refactor spike remove lerna (#135) * got storybook working tests not working yet * fixed tests using jest, and removed CRA dependency, updated babel config for babel 7 and stubbed css files for jest tests for css node modules * Added support for demo app in storybook * fixed eslint CRA had it's own linter internally, so added linting + dependencies * cleaned up export scripts in package.json * updated README * finalised refactor see PR description for more details * rename demo app editor to demoTranscript * bringing back style lint, and fixing lint in storybook config * updated with current master AWS adapter * linting * fix #132 playtime displaied double playtime on display is double of actual total playtime * temporary fix #73 monospace duration and current time in media player to stop moving while playing * Feature: Added custom css loading to storybook (#136) * Resolved conflict iwth AWS adapter
Is your Pull Request request related to another issue in this repository ?
A spike on branch monorepo-refactor
Describe what the PR does
Util
State whether the PR is ready for review or whether it needs extra work
still working on it
Additional context
🚀