Skip to content

Fix #133 speaker not editable in read only mode #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pietrop
Copy link
Contributor

@pietrop pietrop commented Oct 7, 2019

Is your Pull Request request related to another issue in this repository ?

#133

Describe what the PR does

Fixes #133

State whether the PR is ready for review or whether it needs extra work

Ready to merge

Additional context

Working towards #141 but thought I'd make smaller PR for this since it's a distinct issue.

@pietrop pietrop changed the title Fix 133 speaker not editable in read only mode Fix #133 speaker editable in read only mode Oct 7, 2019
@pietrop pietrop changed the title Fix #133 speaker editable in read only mode Fix #133 speaker not editable in read only mode Oct 7, 2019
Pietro Passarelli added 2 commits October 7, 2019 16:11
if isEditable is true can edit speaker label, if false, cannot
Copy link
Contributor

@emettely emettely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

Seeing that this is a relatively small fix (non-blocking I assume), I'll hold out deploying a newer version until a related change #141 is also fixed. Let me know @pietrop :)

@emettely emettely merged commit 2e03334 into bbc:master Oct 9, 2019
@pietrop pietrop deleted the fix-133-speaker-not-editable-in-read-only-mode branch April 23, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speakername is editable even when edit function is disabled
2 participants