-
Notifications
You must be signed in to change notification settings - Fork 165
Adapters - Guide Docs #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
added some details on how to create new adapters, with explanation of draftJs, block, entityRanges, and entityMap
], | ||
"start": 13.02 | ||
}, | ||
"entityRanges": [ // <-- entity ranges |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think you really need this + line 34 as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this? as in the custom data? or the example code?
lol, yeah no, I mean they are for the tests, altho they could be made smaller. I had made a note that we should see if we can exclude them from the bundle so that they are not shipped with the packaged component. for example in
so there might be a way to add them to the |
I've excluded sample files adding |
otherwise would set to latest 11 which doesn't seem to work with npm
merging as a first draft |
Following up from #38 added some guides in the docs for how to create new adapters.
At draft stage, feedback welcome.
especially on
*refactor: as in should we re-factor the code (perhaps at a later stage) to make the adapter creation process even more straightforward?