Settings panel spike #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed background colour to grey and text colour to white, using cog unicode emoji in btn label
added 5 commits
December 18, 2018 17:47
clicking on currentTime triggeres promptSetCurrentTime function
added playbackRate in MediaPlayer PlayerControl with custom select
|
recap from issue #48 - updated with current PR Main control bar
Settings
cheat sheets
Other integration
|
added 7 commits
December 18, 2018 22:21
moved value in state of TranscriptEditor passed into MediaPlayer and changed by Settings via handle callback
rollback value was not neing passed in MediaPlayer in getDerivedStateFromProps
works, might need a forced re-render? it updates, but takes a while to show, sometimes only show if you click on the timecode?
|
As mentioned in the commit had a first pass at adding timecode offsets in TimedTextEditor. |
added 2 commits
December 19, 2018 18:39
same probelm as timecode offset, doesn't instantly re-render until next click
|
Having same issue (of not auto re-rendingering on update)with hide/show time-codes and speaker labels |
re-introduced decreasePlaybackRate and increasePlaybackRate in MediaPlayer
see comment above function
find returns and object, so needed to add .value, also decided that playbackRate value is always going to be a float, so adding parseFloat to event handler from PlayerControls and changed PLAYBACK_RATES values to be floats
…t-editor into settings-panel-spike
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress
Setting it up as separate branch and PR to try out some ideas.
referencing #48