Skip to content

fixed single click fast forward/rewind #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

pietrop
Copy link
Contributor

@pietrop pietrop commented Dec 21, 2018

Is your Pull Request request related to another issue in this repository ?

addressing #47 -Fast forward/rewind - single click bug

Expecting Fast forward/rewind button to work fast forwarding or rewinding even if user only click once.

Describe what the PR does

Fixed single click fast forward/rewind, with previous bug it would only fast forward or rewind on single click, just fixed it so that it also works on single click

State whether the PR is ready for review or whether it needs extra work

Ready for review

Additional context

@jamesdools option to merge into settings-panel-spike directly or wait for settings-panel-spike to be merged into master and merge to master afterwards. Whatever is easier.

but was that it would only fast forward or rewind on single click, just fixed it so that it also works on single click
@pietrop pietrop requested a review from jamesdools December 21, 2018 14:48
@pietrop pietrop changed the base branch from settings-panel-spike to master December 21, 2018 15:48
@pietrop pietrop merged commit 93aaebd into master Dec 21, 2018
@pietrop pietrop deleted the fix-fast-forward-rewind-single-click branch December 21, 2018 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants