fixed local media local storage issue #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added optional fileName param to use as key for saving local media into local storage. only catch is that the mediaUrl should be present along side the transcriptData when initialising the component
jamesdools
approved these changes
Jan 11, 2019
added 2 commits
January 14, 2019 12:59
max value needs to be cast to string
This was referenced Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your Pull Request request related to another issue in this repository ?
Related to Issue #71
Save to local storage does not work with local media (eg blobs).Describe what the PR does
added optional
fileNameparam to use as key for saving local media into local storage.State whether the PR is ready for review or whether it needs extra work
Ready for review
Additional context
Only catch is that the mediaUrl should be present along side the transcriptData when initialising the component. Eg I've added some logic in demo app to make sure media is present when uploading transcript json.