Skip to content

docs: fix the table in pin.rst to match the diagram#659

Merged
dpgeorge merged 1 commit intobbcmicrobit:masterfrom
mattheww:2019-04_pin.rst
Apr 9, 2019
Merged

docs: fix the table in pin.rst to match the diagram#659
dpgeorge merged 1 commit intobbcmicrobit:masterfrom
mattheww:2019-04_pin.rst

Conversation

@mattheww
Copy link
Contributor

@mattheww mattheww commented Apr 8, 2019

The pin table in pins.rst disagrees with the diagram:

  • it says three of the edge connector pins are for the LED rows, rather than columns 7, 8, and 9;
  • it has the three SPI pins in the opposite order

I think the diagram is right and the table is wrong:

  • pinmap.csv says the three LED pins are internal GPIOs 10,11,12 which are definitely columns;
  • spi.rst has sclk=pin13, mosi=pin15, miso=pin14 .

@dpgeorge dpgeorge merged commit a92ca9b into bbcmicrobit:master Apr 9, 2019
@dpgeorge
Copy link
Member

dpgeorge commented Apr 9, 2019

Thanks for the contribution, you are correct!

The fix here also matches the code, source/microbit/microbitspi.cpp, and the display pin mappings in source/microbit/microbitdisplay.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants