CMS-1290: Create winter seasons and implement winter season's form #383

ayumi-oxd · 2025-11-13T18:51:29Z

Jira Ticket

CMS-1080
CMS-1290
CMS-1357
CMS-1359

Description

Backend: Season Model and API Enhancements

Added the seasonType field to the season model and API responses, allowing seasons to be distinguished as either "regular" or "winter". This enables the system to treat winter operations separately from regular park operations.
Modified API endpoints to filter and group date ranges and seasons by their seasonType, and to provide separate grouped date ranges for winter seasons (winterGroupedDateRanges).

Backend: Winter Season Creation Script

Added a new script (create-winter-seasons.js with documentation) that:
- Identifies parks with winter fee dates, removes winter fee date ranges from regular seasons, creates new winter seasons for a specified year if they do not exist, and migrates winter fee date ranges to these winter seasons.

Frontend: Display and Prop Types Updates

Updated the frontend table component to handle and display both regular and winter seasons, including showing winter fee date ranges in parks that support them.

Backend: Ready-to-Publish API Improvements

Enhanced the ready-to-publish endpoint to include the seasonType in its response and to display operating years differently for winter seasons (e.g., "2027 Winter fee").

Copilot

Pull Request Overview

This PR adds support for winter seasons in the BC Parks Staff Portal. It separates winter fee date management from regular season operations by introducing a dedicated winter season type that runs parallel to regular seasons.

Key Changes:

Adds winter season tracking and management alongside regular seasons
Creates backend script to migrate Winter fee DateRanges from regular to winter seasons
Updates UI to display and edit winter season dates separately

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`frontend/src/router/pages/EditAndReview.jsx`	Updates to handle separate regular and winter season objects in park data structure
`frontend/src/components/SeasonForms/ParkSeasonForm.jsx`	Adds winter season form section with dedicated date range management
`frontend/src/components/ReadyToPublishBox.jsx`	Extends component to support both regular and winter season types with conditional rendering
`frontend/src/components/FormPanel.jsx`	Integrates winter season data handling in form save/submit logic
`frontend/src/components/EditAndReviewTable.jsx`	Updates table to display winter season dates alongside regular season dates
`backend/tasks/create-winter-seasons/create-winter-seasons.js`	New script to create winter seasons and migrate Winter fee DateRanges
`backend/tasks/create-winter-seasons/README.md`	Documentation for the winter season creation script
`backend/routes/api/seasons.js`	Adds winter season data fetching and refactors save logic into reusable function
`backend/routes/api/publish.js`	Adds seasonType to query results for approved seasons
`backend/routes/api/parks.js`	Updates park data structure to return separate regular and winter seasons

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

backend/tasks/create-winter-seasons/create-winter-seasons.js

backend/routes/api/parks.js

frontend/src/components/EditAndReviewTable.jsx

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

backend/routes/api/seasons.js

frontend/src/components/EditAndReviewTable.jsx

backend/routes/api/parks.js

molund · 2025-11-24T21:33:59Z

backend/routes/api/parks.js

 }

 // build a current season object
 function buildCurrentSeasonOutput(seasons) {


This is always called but the value is only conditionally used in the output. The call should be moved inside the condition.

What condition did you mean?

molund · 2025-11-24T21:46:17Z

The PR title somewhat downplays the magnitude of this change. Can we change it to something like "Implement and enable winter seasons"

backend/tasks/create-winter-seasons/create-winter-seasons.js

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

backend/utils/seasonHelpers.js

backend/tasks/create-winter-seasons/README.md

backend/routes/api/seasons.js

duncan-oxd

Great work! I didn't get a chance to review it all today, but I left a few comments about potential optimizations to consider 👍

duncan-oxd · 2025-12-19T18:44:40Z

frontend/src/components/SeasonForms/ParkSeasonForm.jsx

+    tempId = false,
+    seasonType = "regular",
+  ) {
+    const seasonData = seasonType === "winter" ? winterSeason : season;


Let's create a constants file for seasonType to have these "winter" and "regular" strings. I could imagine us changing it to a numerical ID in the future (and/or adding more special kinds of seasons for Tier 1/2, etc.) So it would be great to have this as constant variables from the start 👍

duncan-oxd · 2025-12-19T18:51:18Z

backend/routes/api/publish.js

+      if (publishable?.type === "park") {
+        displayOperatingYear =
+          season.seasonType === "winter"
+            ? `${season.operatingYear} Winter fee`
+            : `${season.operatingYear} Tiers and gate`;
+      }


It might make sense to move this logic into the template. It's fine to leave it in this case too, because it's only used in one place/file, but we'd need it in the template if we ever have to wrap "Tiers and gate" in a <b> tag, for example. It's no problem if we leave it here for this branch though 👍

duncan-oxd · 2025-12-19T19:07:05Z

backend/routes/api/parks.js

-// get all date ranges from seasons
 function getAllDateRanges(seasons) {


Is that comment no longer accurate? We should have some kind of comment to document what the function does

duncan-oxd · 2025-12-19T19:12:06Z

backend/routes/api/parks.js

+      const regularSeasons = park.seasons.filter(
+        (season) => season.seasonType === "regular",
+      );
+      const winterSeasons = park.seasons.filter(
+        (season) => season.seasonType === "winter",
+      );


If you ever need to split a collection into two, you can use lodash's partition function to do that, and then you don't have to write two expressions and loop over the collection twice

duncan-oxd · 2025-12-19T20:26:57Z

backend/tasks/create-seasons/README.md

+   - Finds all parks that have at least one active feature
+   - Ensures each park has required `publishableId` and `dateableId` (creates them if missing)
+   - Creates a new Season record for the specified operating year
+   - Creates blank Tier 2 date ranges for parks that had them in the previous year


Out of scope for this ticket, but we should probably eventually move this logic into the "create blank dates" script(s), now that we have dedicated scripts to do that

duncan-oxd · 2025-12-19T20:53:12Z

backend/tasks/create-winter-seasons/create-winter-seasons.js

+// Get the Winter fee DateType
+const winterFeeDateType = await DateType.findOne({
+  where: {
+    name: "Winter fee",


Some environments still have two date types with the name "Winter fee" - (a park-level one and an area/feature-level one). We can probably clean that up by updating the "parklevel" and "featurelevel" values and deleting the extra record, but this query with no WHERE might cause problems until then 😬

The extra record (id = 13) should be gone from all environments now.

ayumi-oxd self-assigned this Nov 13, 2025

ayumi-oxd added WIP v2.3.0 labels Nov 13, 2025

ayumi-oxd requested a review from Copilot November 21, 2025 01:23

Copilot AI reviewed Nov 21, 2025

View reviewed changes

backend/tasks/create-winter-seasons/create-winter-seasons.js Outdated Show resolved Hide resolved

backend/routes/api/parks.js Show resolved Hide resolved

frontend/src/components/EditAndReviewTable.jsx Outdated Show resolved Hide resolved

ayumi-oxd requested a review from Copilot November 21, 2025 20:38

Copilot AI reviewed Nov 21, 2025

View reviewed changes

ayumi-oxd removed the WIP label Nov 21, 2025

ayumi-oxd requested a review from molund November 21, 2025 22:31

molund reviewed Nov 24, 2025

View reviewed changes

backend/tasks/create-winter-seasons/create-winter-seasons.js Outdated Show resolved Hide resolved

molund reviewed Nov 24, 2025

View reviewed changes

backend/tasks/create-winter-seasons/create-winter-seasons.js Outdated Show resolved Hide resolved

ayumi-oxd added the WIP label Nov 27, 2025

ayumi-oxd force-pushed the CMS-1290-winter-season branch from d79d59a to e6bf070 Compare December 4, 2025 18:19

ayumi-oxd changed the title ~~CMS-1290: Add winter season script~~ CMS-1290: Create winter seasons and implement winter season's form Dec 12, 2025

ayumi-oxd requested a review from Copilot December 16, 2025 17:41

Copilot AI reviewed Dec 16, 2025

View reviewed changes

ayumi-oxd requested review from duncan-oxd and molund December 16, 2025 18:17

ayumi-oxd removed the WIP label Dec 16, 2025

ayumi-oxd force-pushed the CMS-1290-winter-season branch 2 times, most recently from b5878e9 to cd19e7b Compare December 19, 2025 20:34

duncan-oxd requested changes Dec 19, 2025

View reviewed changes

ayumi-oxd added 6 commits December 19, 2025 14:27

CMS-1290: Add winter season script

09e81d7

CMS-1290: Add winter season to park

2ce43ac

CMS-1290: Update form panel

4f1aac9

CMS-1290: Add winter fee flag to publish page

8e5ccb7

CMS-1290: Code clean up

3b621d5

CMS-1290: Add winter fee form

4af4129

ayumi-oxd added 5 commits December 19, 2025 14:31

CMS-1290: Update winter fee form

0779a18

CMS-1290: Update create-seasons script

c89f745

CMS-1290: Update winter fee season status row

8e83e12

CMS-1290: Fix winter fee season note bug

6563100

CMS-1290: Code refactor by copilot

62454b3

ayumi-oxd force-pushed the CMS-1290-winter-season branch from cd19e7b to 62454b3 Compare December 19, 2025 22:31

ayumi-oxd added 2 commits December 22, 2025 15:13

CMS-1290: Add season type constant file to frontend

8c843c4

CMS-1290: Add season type constant file to backend

88991f6

ayumi-oxd requested a review from duncan-oxd December 22, 2025 23:56

		// get all date ranges from seasons
		function getAllDateRanges(seasons) {

CMS-1290: Create winter seasons and implement winter season's form #383

Are you sure you want to change the base?

CMS-1290: Create winter seasons and implement winter season's form #383

Uh oh!

Conversation

ayumi-oxd commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jira Ticket

Description

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

molund commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

duncan-oxd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ayumi-oxd commented Nov 13, 2025 •

edited

Loading

molund commented Nov 24, 2025 •

edited

Loading