Skip to content

Added ignoreMinAndMaxItems option #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2020
Merged

Added ignoreMinAndMaxItems option #274

merged 2 commits into from
Feb 22, 2020

Conversation

lukeggchapman
Copy link
Contributor

@lukeggchapman lukeggchapman commented Jan 23, 2020

Fixes #250

Added ignoreMinAndMaxItems to prevent tuples from being generated for array types.

Tuples can cause issues when there is a high value for maxItems, and they don't work well with array utility methods (.map, .filter). It's unlikely that TS will fix these issues anytime soon given tuples should be a fixed length.

@lukeggchapman lukeggchapman changed the title Added ignoreMinAndMaxItems option to prevent tuples from being generated for array types Added ignoreMinAndMaxItems option Jan 23, 2020
Copy link
Owner

@bcherny bcherny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG -- thanks for the contribution! Sending this back to your queue for a few minor touch-ups before we merge this.

@lukeggchapman lukeggchapman requested a review from bcherny January 27, 2020 22:55
Copy link
Owner

@bcherny bcherny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@bcherny bcherny merged commit 1d24618 into bcherny:master Feb 22, 2020
@bcherny
Copy link
Owner

bcherny commented Feb 22, 2020

Published 8.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add switch to disable the minItems/maxItems expanding
2 participants