Update arm velocity control function #173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces support for arm velocity control on the Spot robot.
Reference: #104.
In the referenced implementation, the protobuf message was being reconstructed manually, which led to some issues. In this version, I simply copy the end_time field to the existing protobuf, avoiding the need to create a new one.
Based on the discussions in the PR, this is the approach @tcappellari-bdai preferred. It also enables us to leverage direct ROS-to-protobuf conversion without needing to explicitly map each field in a custom function.
I tested this thoroughly with cylindrical and angular velocity commands, and performed basic tests with cartesian velocity commands.
Related spot_ros2 PR: bdaiinstitute/spot_ros2#704