Skip to content

Update arm velocity control function #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025

Conversation

kabirkedia
Copy link
Contributor

@kabirkedia kabirkedia commented Jul 17, 2025

This change introduces support for arm velocity control on the Spot robot.

Reference: #104.
In the referenced implementation, the protobuf message was being reconstructed manually, which led to some issues. In this version, I simply copy the end_time field to the existing protobuf, avoiding the need to create a new one.

Based on the discussions in the PR, this is the approach @tcappellari-bdai preferred. It also enables us to leverage direct ROS-to-protobuf conversion without needing to explicitly map each field in a custom function.

I tested this thoroughly with cylindrical and angular velocity commands, and performed basic tests with cartesian velocity commands.

Related spot_ros2 PR: bdaiinstitute/spot_ros2#704

Copy link
Collaborator

@khughes-bdai khughes-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@khughes-bdai khughes-bdai merged commit 12afad0 into bdaiinstitute:main Jul 17, 2025
4 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 16350256683

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 44.867%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spot_wrapper/spot_arm.py 0 2 0.0%
Totals Coverage Status
Change from base Build 15717190247: 0.0%
Covered Lines: 2181
Relevant Lines: 4861

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants