Skip to content

🐛 [DropDownButton] closeAfterClick at item level is ignored #1245

@Nico04

Description

@Nico04

Setting closeAfterClick at MenuFlyoutItem level doesn't work, only at DropDownButton.

This part of the code looks involved :

  MenuFlyoutItem _createMenuItem(MenuFlyoutItem item, BuildContext context) {
    return MenuFlyoutItem(
      onPressed: item.onPressed,
      closeAfterClick: widget.closeAfterClick,
      key: item.key,
      leading: item.leading,
      text: item.text,
      trailing: item.trailing,
      selected: item.selected,
    );
  }

It may be changed to this :

  MenuFlyoutItem _createMenuItem(MenuFlyoutItem item, BuildContext context) {
    return MenuFlyoutItem(
      onPressed: item.onPressed,
      closeAfterClick: item.closeAfterClick ?? widget.closeAfterClick,
      key: item.key,
      leading: item.leading,
      text: item.text,
      trailing: item.trailing,
      selected: item.selected,
    );
  }

And change item.closeAfterClick to be nullable.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions