Skip to content

Use PageView to build the view content#607

Merged
bdlukaa merged 6 commits intomasterfrom
page-view-body
Nov 21, 2022
Merged

Use PageView to build the view content#607
bdlukaa merged 6 commits intomasterfrom
page-view-body

Conversation

@bdlukaa
Copy link
Copy Markdown
Owner

@bdlukaa bdlukaa commented Nov 10, 2022

PaneItem.bodyKey is now assigned to every PaneItem.body to preserve its state. Improved, fundamentally, how the current body management works. Additionally, .bodyKey can be used to find measurements for the body content, if needed in the future.

Fixed #604

Pre-launch Checklist

  • I have updated CHANGELOG.md with my changes
  • I have run "dart format ." on the project
  • I have added/updated relevant documentation

@henry2man
Copy link
Copy Markdown
Contributor

henry2man commented Nov 10, 2022

It works like a charm, but some changes are needed in order to make paneBodyBuilder works (again)

@henry2man

This comment was marked as resolved.

@bdlukaa bdlukaa marked this pull request as ready for review November 12, 2022 13:29
@bdlukaa bdlukaa mentioned this pull request Nov 14, 2022
3 tasks
@bdlukaa bdlukaa changed the title [wip] Use PageView to build the view content Use PageView to build the view content Nov 14, 2022
Comment thread lib/src/controls/navigation/navigation_view/body.dart Outdated
@bdlukaa bdlukaa merged commit 8fe78e6 into master Nov 21, 2022
@bdlukaa bdlukaa deleted the page-view-body branch November 21, 2022 21:08
@ReggieMiller1
Copy link
Copy Markdown

it didnt work even when i used pageBuilder...i'll try to upgrade to the latest upgrade of the package and see if it will work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AutomaticKeepAliveClientMixin

3 participants