Skip to content

Fix number of arguments of overridden methods from _FluentTextSelectionControls #68

Merged
bdlukaa merged 1 commit intobdlukaa:masterfrom
JeanJPNM:add-overridden-pos-args
Sep 15, 2021
Merged

Fix number of arguments of overridden methods from _FluentTextSelectionControls #68
bdlukaa merged 1 commit intobdlukaa:masterfrom
JeanJPNM:add-overridden-pos-args

Conversation

@JeanJPNM
Copy link
Copy Markdown
Contributor

@JeanJPNM JeanJPNM commented Sep 15, 2021 •
edited
Loading

Fixes #67 by adding the missing positional parameters in methods overridden by the class _FluentTextSelectionControls.

Pre-launch Checklist

  • I have run dartfmt on all changed files
  • I have updated CHANGELOG.md with my changes
  • I have run "optimize/organize imports" on all changed files
  • I have addressed all analyzer warnings as best I could
  • I have added/updated relevant documentation
  • I have run flutter pub publish --dry-run and addressed any warnings

@JeanJPNM JeanJPNM changed the title Fix number of arguments of overriden methods from _FluentTextSelectionControls Fix number of arguments of overridden methods from _FluentTextSelectionControls Sep 15, 2021
bdlukaa
bdlukaa approved these changes Sep 15, 2021
View reviewed changes
Copy link
Copy Markdown
Owner

@bdlukaa bdlukaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bdlukaa bdlukaa merged commit 46735dc into bdlukaa:master Sep 15, 2021
@JeanJPNM JeanJPNM deleted the add-overridden-pos-args branch September 15, 2021 14:54
WinXaito pushed a commit to WinXaito/fluent_ui that referenced this pull request Nov 28, 2021
@bdlukaa
Fix number of arguments of overridden methods from `_FluentTextSelect…
4d4e8d4 
…ionControls` (bdlukaa#68)
@mesharkw mesharkw mentioned this pull request Jul 12, 2023
Closed
dev-hann added a commit to dev-hann/fluent_ui that referenced this pull request Sep 18, 2023
@dev-hann
Fix number of arguments of overridden methods from `_FluentTextSelect…
40383dd 
…ionControls` (bdlukaa#68)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdlukaa bdlukaa bdlukaa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

error G76A9B1F6: The method '_FluentTextSelectionControls.buildHandle' has fewer positional arguments than those of overridden method

2 participants

@JeanJPNM @bdlukaa