Allow paneBodyBuilder to use an IndexedStack without interference#680
Merged
bdlukaa merged 4 commits intobdlukaa:masterfrom Jan 17, 2023
Merged
Allow paneBodyBuilder to use an IndexedStack without interference#680bdlukaa merged 4 commits intobdlukaa:masterfrom
bdlukaa merged 4 commits intobdlukaa:masterfrom
Conversation
A common use case for paneBodyBuilder is to use an IndexedStack to manage the state of the widgets displayed inside the navigation body. An IndexedStack does not play nicely with the PageView.builder that it was being wrapped in. Now, if a paneBodyBuilder is used, assume it is responsible for its own state management. Fixes bdlukaa#679
Contributor
Author
|
Note that this has been tested not to change the previous behavior if |
bdlukaa
reviewed
Jan 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #679, as well as the minor assertion in #678.