Skip to content

Improve example in Navigation/NavigationView#796

Merged
bdlukaa merged 2 commits into
bdlukaa:masterfrom
Tsuzat:master
Mar 31, 2023
Merged

Improve example in Navigation/NavigationView#796
bdlukaa merged 2 commits into
bdlukaa:masterfrom
Tsuzat:master

Conversation

@Tsuzat
Copy link
Copy Markdown
Contributor

@Tsuzat Tsuzat commented Mar 31, 2023

In a previous update, One can add/remove item(s) in NavigationPane but there was no implementation of this feature in the example application.
So, the following changes are made

  • Add the PaneAction named Add New Item which adds a new item in NavigationPane.
  • Refactor the code to achieve this, i.e. Moved items outside the Widget Build function and added PaneAction in footerItems.
  • Refactor the code snippet according to implementation.

Before
Screenshot 2023-03-31 111442

After
ezgif-5-8749d1d32b

Pre-launch Checklist

  • I have updated CHANGELOG.md with my changes
  • I have run "dart format ." on the project
  • I have added/updated relevant documentation

Comment thread example/lib/screens/navigation/navigation_view.dart Outdated
Comment thread example/lib/screens/navigation/navigation_view.dart Outdated
Comment thread example/lib/screens/navigation/navigation_view.dart Outdated
@Tsuzat
Copy link
Copy Markdown
Contributor Author

Tsuzat commented Mar 31, 2023

Hey, I have made changes and amended the commit. Also, double quotes have been changes to single quotes in Code Snipppet too.

@Tsuzat Tsuzat requested a review from bdlukaa March 31, 2023 11:38
@bdlukaa bdlukaa merged commit cc6d10f into bdlukaa:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants