`plot_confusion_matrix` cannot change `annotation_text_size`

[abhinav3398]

I was trying to increase the text size of my confusion matrix plot. But when I tried to pass in the keyword arg annotation_text_size=34 it gave me an error. The code works fine without the keyword args (Lighthouse.plot_confusion_matrix(rand(2, 2), ["1", "2"], :Row)) and produces a confusion matrix plot. But when I try to change the default text size it gave me this error:

Lighthouse.plot_confusion_matrix(rand(2, 2), ["1", "2"], :Row, annotation_text_size=34)

MethodError: no method matching plot_confusion_matrix(::Matrix{Float64}, ::Vector{String}, ::Symbol; annotation_text_size=34)

Closest candidates are:

plot_confusion_matrix(::AbstractMatrix, ::Any, ::Any) at ~/.julia/packages/Lighthouse/K3PBy/src/learn.jl:333 got unsupported keyword argument "annotation_text_size"

here are my environment/system info, if it's of any help:

Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
  CPU: Intel(R) Core(TM) i3-4030U CPU @ 1.90GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, haswell)

Environment:
  JULIA_REVISE_WORKER_ONLY = 1
      Status `~/usr/project/dir/Project.toml`
  [ac2c24cd] Lighthouse v0.11.3

[abhinav3398]

haven't tried other methods yet. Let me know if it's the same with the other methods as well.

[palday]

Current Lighthouse version is 0.14.10 -- does this work when you update from v0.11.3?

[abhinav3398]

@palday nope! [ac2c24cd] Lighthouse v0.14.10

MethodError: no method matching plot_confusion_matrix(::Matrix{Float64}, ::Vector{String}, ::Symbol; annotation_text_size=34)

Closest candidates are:

plot_confusion_matrix(::AbstractMatrix, ::Any, ::Any) at ~/.julia/packages/Lighthouse/K3PBy/src/learn.jl:333 got unsupported keyword argument "annotation_text_size"

[palday]

Have you restarted your Julia session? This what the referenced source line looks like now:

Lighthouse.jl/src/learn.jl

Line 333 in 0540cdd

train!(model, get_train_batches(), logger)

The methods for plot_confusion_matrix[!] are defined here:

Lighthouse.jl/src/plotting.jl

Lines 182 to 184 in 0540cdd

	function plot_confusion_matrix!(subfig::FigurePosition, confusion::NumberMatrix,
	class_labels::AbstractVector{String}, normalize_by::Symbol;
	annotation_text_size=20, colormap=:Blues)

Lighthouse.jl/src/plotting.jl

Lines 404 to 425 in 0540cdd

	"""
	plot_confusion_matrix!(subfig::FigurePosition, args...; kw...)
	plot_confusion_matrix(confusion::AbstractMatrix{<: Number}, class_labels::AbstractVector{String}, normalize_by::Symbol;
	resolution=(800,600),
	annotation_text_size=20)
	Lighthouse plots confusion matrices, which are simple tables
	showing the empirical distribution of predicted class (the rows)
	versus the elected class (the columns). These come in two variants:
	* row-normalized: this means each row has been normalized to sum to 1. Thus, the row-normalized confusion matrix shows the empirical distribution of elected classes for a given predicted class. E.g. the first row of the row-normalized confusion matrix shows the empirical probabilities of the elected classes for a sample which was predicted to be in the first class.
	* column-normalized: this means each column has been normalized to sum to 1. Thus, the column-normalized confusion matrix shows the empirical distribution of predicted classes for a given elected class. E.g. the first column of the column-normalized confusion matrix shows the empirical probabilities of the predicted classes for a sample which was elected to be in the first class.
	```
	fig, ax, p = plot_confusion_matrix(rand(2, 2), ["1", "2"], :Row)
	fig = Figure()
	ax = plot_confusion_matrix!(fig[1, 1], rand(2, 2), ["1", "2"], :Column)
	```
	"""
	plot_confusion_matrix(args...; kw...) = axisplot(plot_confusion_matrix!, args; kw...)

[abhinav3398]

Lighthouse.plot_confusion_matrix(rand(2, 2), ["1", "2"], :Row, annotation_text_size=34)

restarting the session made things worse. Now i don't have any plot. Before I at least had a plot. Now instead of plot i get this as output to above code:
FigureAxisPlot()

[ericphanson]

That's a Makie object: https://makie.juliaplots.org/v0.17.3/documentation/plot_method_signatures/index.html#non-mutating. It should show you a plot, but you need to have a Makie backend loaded. See the Makie docs here on backends: https://makie.juliaplots.org/v0.17.3/documentation/backends/.

[abhinav3398]

Okay yup, using WGLMakie as a backend did the trick. But, was this mentioned in the docs that we have to activate one of the Maxkie backend?

[ericphanson]

No, good point, we should mention it. I'll file an issue for that.