Unify CI and grammar cache keys #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CI grammar cache key was missing xtask source changes, causing stale parsers to be published (e.g., PR bearcove#77's ABI 15 fix didn't take effect because ABI 14 parsers were served from cache). Solution: Two-layer caching with single source of truth. Layer 1: Cache xtask binary - Key: hashFiles('xtask/Cargo.lock', 'xtask/src/**/*.rs') - Invalidates when generator code changes Layer 2: Cache grammar generation - Key: computed by `xtask cache-key` at runtime - Reuses existing compute_cache_key() logic which hashes: - tree-sitter CLI version - grammar.js and grammar/ files - common/ directory - dependency grammars When xtask source changes, Layer 1 misses → xtask rebuilds → xtask cache-key produces fresh hash → Layer 2 also invalidates.
zharinov
changed the title
Collaborator
Aaaah crap thanks for looking into it. |
Collaborator
|
I pushed v2.4.6 — should release itself gently over the next.. 15 minutes. |
Contributor
Author
|
No problem! It was the beautiful Opus session 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CI grammar cache didn't invalidate when generator code changed, causing stale parsers to be published (e.g., PR #77's ABI 15 fix didn't take effect).
Solution
Two-layer caching:
xtask/Cargo.lock+xtask/src/**/*.rsxtask cache-keyoutput, withrestore-keysfor incremental rebuildsThe
xtask cache-keycommand reuses existingcompute_cache_key()logic (tree-sitter version, grammar files, dependencies).