Switch from facet-postcard to facet-format-postcard with JIT #44
+528
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the deprecated facet-postcard crate with the new facet-format-postcard crate which supports JIT-accelerated deserialization via Cranelift. This is a drop-in replacement with the same API.
There was a problem hiding this comment.
Pull request overview
This PR replaces facet-postcard with facet-format-postcard (with JIT feature enabled via Cranelift) for improved deserialization performance. The migration is a drop-in replacement with an identical API.
- Mechanical replacement of
facet_postcardwithfacet_format_postcardthroughout the codebase - Enabled JIT feature for Cranelift-accelerated deserialization
- Updated facet dependencies from 0.34.0 to 0.35.0
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/picante/tests/persist.rs | Updated test code to use new library for cache serialization |
| crates/picante/src/wal.rs | Updated WAL header and entry serialization/deserialization |
| crates/picante/src/persist.rs | Updated cache file encode/decode functions |
| crates/picante/src/key.rs | Updated key encoding/decoding methods |
| crates/picante/src/ingredient/interned.rs | Updated interned record serialization with improved code formatting |
| crates/picante/src/ingredient/input.rs | Updated input record serialization with improved code formatting |
| crates/picante/src/ingredient/derived.rs | Updated derived record serialization/deserialization |
| crates/picante/Cargo.toml | Replaced dependency with facet-format-postcard |
| Cargo.toml | Replaced dependency with facet-format-postcard, enabled jit feature |
| Cargo.lock | Updated lock file with new dependencies (Cranelift, facet 0.35.0) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
facet-postcardwithfacet-format-postcard(withjitfeature enabled)