Don't require empty rows in user_items and item_users #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the recommend call, user_items required empty rows to be passed for users that weren't being recommended - and likewise the similar_items had a item_users param with the same restriction. When generating recommendations for a single user, if the userid is large - we'd have to generate a vector with an entry for each smaller userid. Change this to use the passed in 'userid' array, and just have the rows in the user_items sparse matrix match those in the userid array.
This was referenced Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the recommend call, user_items required empty rows to be passed for users that
weren't being recommended - and likewise the similar_items had a item_users param
with the same restriction. When generating recommendations for a single user,
if the userid is large - we'd have to generate a vector with an entry for each smaller userid.
Change this to use the passed in 'userid' array, and just have the rows in the user_items
sparse matrix match those in the userid array.