Add check_csr for partial_fit methods #683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were seeing some poor result on partial_fit_*, that ended up caused by passing a CSC instead of a CSR matrix. (#682) Add the same `check_csr` code to the partial_fit methods that is already done in the fit method - this will warn if passed a non-csr matrix, and automatically convert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing some poor result on partial_fit_*, that ended up caused by passing a CSC instead of a CSR matrix. (#682)
Add the same
check_csrcode to the partial_fit methods that is already done in the fit method - this will warn if passed a non-csr matrix, and automatically convert.