fix(Gallery): Should update thumbnails when maxRows changes#35
Merged
benhowell merged 1 commit intobenhowell:masterfrom Jul 20, 2017
Merged
fix(Gallery): Should update thumbnails when maxRows changes#35benhowell merged 1 commit intobenhowell:masterfrom
benhowell merged 1 commit intobenhowell:masterfrom
Conversation
Owner
|
Thanks very much @SimeonC, nice catch! |
Contributor
Author
|
Wow, so quick!! Thanks. |
Owner
|
No worries! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was using some JS to change whether we showed 1 row or two on a breakpoint and some other funky js due to SSR which meant I have to render 1 row then figure out if we show 2 and noticed that when I changed the maxRows setting the thumbnails didn't update.
This PR fixes that.