Add CADDX Protos preset #557
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📝 WalkthroughWalkthroughAdds a new experimental Betaflight 4.5 factory tuning preset for the CADDX Protos F4: a single profile with gyro filtering, dynamic notch, RPM filter, feedforward, and simplified PID/FF tuning for 2S freestyle flight (STM32F405). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
Fix all issues with AI Agents 🤖
In @presets/4.5/tune/caddx/CADDX_Protos.txt:
- Around line 1-9: Add a new metadata header line "#$ DISCUSSION: PR #557"
immediately after the existing header block (below lines like "#$ AUTHOR:
CADDXFPV" and "#$ PARSER: MARKED") so the preset includes the required
DISCUSSION field referencing PR #557 to centralize feedback and maintain preset
lineage.
- Line 2: The preset file incorrectly declares "FIRMWARE_VERSION: 4.5" and is in
the wrong folder; move the file to presets/2025.12/tune/caddx/, update the
header line "FIRMWARE_VERSION:" from "4.5" to "2025.12", and add a new
"DISCUSSION" header line (e.g., "#$ DISCUSSION:
https://github.com/betaflight/firmware-presets/pull/557") near the top to match
other firmware-specific presets and the note that this is intended for
Betaflight 25.12.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
presets/4.5/tune/caddx/CADDX_Protos.txt
🧰 Additional context used
🧠 Learnings (8)
📓 Common learnings
Learnt from: spatzengr
Repo: betaflight/firmware-presets PR: 0
File: :0-0
Timestamp: 2025-12-29T17:25:33.791Z
Learning: In the betaflight/firmware-presets repository, when a preset is updated across firmware versions, the #$ DISCUSSION field should continue to reference the original PR where the preset was first introduced (e.g., PR #210), not the current update PR (e.g., PR #554), to keep all preset-related discussions and feedback centralized in one location.
Learnt from: spatzengr
Repo: betaflight/firmware-presets PR: 0
File: :0-0
Timestamp: 2025-12-29T04:01:38.863Z
Learning: When creating derivative Betaflight presets, the #$ DISCUSSION field should reference the original preset PR number (e.g., PR #202) to maintain preset lineage, not the current PR being reviewed.
Learnt from: bensonk
Repo: betaflight/firmware-presets PR: 509
File: presets/4.5/osd/bensonk.txt:138-152
Timestamp: 2025-05-25T22:26:17.328Z
Learning: BrainFPV commands in Betaflight preset files are safely ignored on non-BrainFPV flight controllers, making it safe to include them in presets even when they might be applied to different hardware.
Learnt from: spatzengr
Repo: betaflight/firmware-presets PR: 0
File: :0-0
Timestamp: 2025-12-29T04:01:38.863Z
Learning: In Betaflight firmware presets, filter defaults from presets/4.5/filters/defaults.txt are shared across firmware versions including 2025.12, as there is no separate defaults.txt file in presets/2025.12/filters/ directory.
Learnt from: haslinghuis
Repo: betaflight/firmware-presets PR: 0
File: :0-0
Timestamp: 2025-12-29T18:54:48.142Z
Learning: In the betaflight/firmware-presets repository (and all Betaflight repositories), preset files use space characters for indentation (typically 2 spaces), not tabs. This is the standard across all firmware versions including 4.5 and 2025.12.
Learnt from: Jaz7Mutant
Repo: betaflight/firmware-presets PR: 512
File: presets/4.5/tune/basher_jazzmutant_tune.txt:118-119
Timestamp: 2025-06-20T20:39:08.723Z
Learning: In Betaflight firmware presets, rates defaults from presets/4.3/rates/defaults.txt are used across multiple firmware versions including 4.5, as the file explicitly declares support for firmware versions 4.3, 4.4, and 4.5. There is no separate defaults.txt file in presets/4.5/rates/ directory.
Learnt from: spatzengr
Repo: betaflight/firmware-presets PR: 0
File: :0-0
Timestamp: 2025-12-29T13:48:41.244Z
Learning: In UAV Tech Betaflight presets, the option label "low Build Quality" uses lowercase 'l' by design and is the established pattern across all UAV Tech presets in versions 4.4, 4.5, and 2025.12.
📚 Learning: 2025-06-20T20:39:08.723Z
Learnt from: Jaz7Mutant
Repo: betaflight/firmware-presets PR: 512
File: presets/4.5/tune/basher_jazzmutant_tune.txt:118-119
Timestamp: 2025-06-20T20:39:08.723Z
Learning: In Betaflight firmware presets, rates defaults from presets/4.3/rates/defaults.txt are used across multiple firmware versions including 4.5, as the file explicitly declares support for firmware versions 4.3, 4.4, and 4.5. There is no separate defaults.txt file in presets/4.5/rates/ directory.
Applied to files:
presets/4.5/tune/caddx/CADDX_Protos.txt
📚 Learning: 2025-12-29T04:01:38.863Z
Learnt from: spatzengr
Repo: betaflight/firmware-presets PR: 0
File: :0-0
Timestamp: 2025-12-29T04:01:38.863Z
Learning: In Betaflight firmware presets, filter defaults from presets/4.5/filters/defaults.txt are shared across firmware versions including 2025.12, as there is no separate defaults.txt file in presets/2025.12/filters/ directory.
Applied to files:
presets/4.5/tune/caddx/CADDX_Protos.txt
📚 Learning: 2025-05-25T22:26:17.328Z
Learnt from: bensonk
Repo: betaflight/firmware-presets PR: 509
File: presets/4.5/osd/bensonk.txt:138-152
Timestamp: 2025-05-25T22:26:17.328Z
Learning: BrainFPV commands in Betaflight preset files are safely ignored on non-BrainFPV flight controllers, making it safe to include them in presets even when they might be applied to different hardware.
Applied to files:
presets/4.5/tune/caddx/CADDX_Protos.txt
📚 Learning: 2025-12-29T17:25:33.791Z
Learnt from: spatzengr
Repo: betaflight/firmware-presets PR: 0
File: :0-0
Timestamp: 2025-12-29T17:25:33.791Z
Learning: In the betaflight/firmware-presets repository, when a preset is updated across firmware versions, the #$ DISCUSSION field should continue to reference the original PR where the preset was first introduced (e.g., PR #210), not the current update PR (e.g., PR #554), to keep all preset-related discussions and feedback centralized in one location.
Applied to files:
presets/4.5/tune/caddx/CADDX_Protos.txt
📚 Learning: 2025-12-29T04:01:38.863Z
Learnt from: spatzengr
Repo: betaflight/firmware-presets PR: 0
File: :0-0
Timestamp: 2025-12-29T04:01:38.863Z
Learning: When creating derivative Betaflight presets, the #$ DISCUSSION field should reference the original preset PR number (e.g., PR #202) to maintain preset lineage, not the current PR being reviewed.
Applied to files:
presets/4.5/tune/caddx/CADDX_Protos.txt
📚 Learning: 2025-12-29T18:54:48.142Z
Learnt from: haslinghuis
Repo: betaflight/firmware-presets PR: 0
File: :0-0
Timestamp: 2025-12-29T18:54:48.142Z
Learning: In the betaflight/firmware-presets repository (and all Betaflight repositories), preset files use space characters for indentation (typically 2 spaces), not tabs. This is the standard across all firmware versions including 4.5 and 2025.12.
Applied to files:
presets/4.5/tune/caddx/CADDX_Protos.txt
📚 Learning: 2025-06-20T18:08:54.334Z
Learnt from: Jaz7Mutant
Repo: betaflight/firmware-presets PR: 512
File: presets/4.5/tune/basher_jazzmutant_tune.txt:1-8
Timestamp: 2025-06-20T18:08:54.334Z
Learning: In Betaflight firmware preset files, embedded double quotes in metadata fields like TITLE and KEYWORDS (e.g., `5"`, `3" to 5"`, `8"/9"`) are standard and do not need escaping. The preset parser handles this syntax correctly as evidenced by widespread usage throughout the codebase.
Applied to files:
presets/4.5/tune/caddx/CADDX_Protos.txt
CADDXFPV
force-pushed
the
CADDX_Protos_Preset
branch
from
5694c41 to
6370dd5
Compare
haslinghuis
requested changes
Jan 5, 2026
haslinghuis
reviewed
Jan 6, 2026
haslinghuis
reviewed
Jan 6, 2026
Removed PID tuning parameters for pitch, roll, and yaw.
haslinghuis
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tune preset made for the CADDX Protos
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.