The CI is too friendly #7424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

tguichaoua opened this issue Jan 30, 2023 · 0 comments

Contributor

tguichaoua commented Jan 30, 2023

The welcome workflow introduced in #7398 resend the welcome message for each commit. cf #7406

rparrett mentioned this issue

[Merged by Bors] - Fix CI welcome message #7428

Closed

bors bot closed this as completed in

ca2d91e

ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue


          Fix CI welcome message (bevyengine#7428)

f654b07

# Objective

Fixes bevyengine#7424

## Solution

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target
> By default, a workflow only runs when a pull_request_target event's activity type is opened, synchronize, or reopened.

Specify `opened` so that this only runs when a PR is opened

While I was in there, I fixed a couple other issues:
- extra indentation that was causing the welcome message to be put in a code block.
- broken relative link in message (was resolving to <https://github.com/bevyengine/bevy/pull/CONTRIBUTING.md>)
- fixed a few other minor typos in the message

cc @mockersf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment