Skip to content

Replace unsafe blocks in World and DeferredWorld with safe equivalents #17206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

Replace unsafe blocks in World and DeferredWorld with safe equivalents #17206

merged 1 commit into from
Jan 7, 2025

Conversation

ItsDoot
Copy link
Contributor

@ItsDoot ItsDoot commented Jan 7, 2025

Objective

Reduce the number of unsafe blocks.

Solution

Replaced 5 unsafe blocks with safe equivalents.

Testing

Reusing current tests

@ItsDoot ItsDoot added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples D-Unsafe Touches with unsafe code in some way labels Jan 7, 2025
@alice-i-cecile alice-i-cecile added the X-Uncontroversial This work is generally agreed upon label Jan 7, 2025
@alice-i-cecile
Copy link
Member

Love to see it frankly.

@ItsDoot ItsDoot added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Jan 7, 2025
@cart cart removed the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Jan 7, 2025
@cart cart added this pull request to the merge queue Jan 7, 2025
Merged via the queue into bevyengine:main with commit d1e5702 Jan 7, 2025
35 checks passed
mrchantey pushed a commit to mrchantey/bevy that referenced this pull request Feb 4, 2025
@ItsDoot @mrchantey
Replace unsafe blocks in World and DeferredWorld with safe equiva…
8787e38 
…lents (bevyengine#17206)

# Objective

Reduce the number of unsafe blocks.

## Solution

Replaced 5 unsafe blocks with safe equivalents.

## Testing

Reusing current tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples D-Unsafe Touches with unsafe code in some way X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ItsDoot @alice-i-cecile @cart