-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Fixed bevy_image
and bevy_gltf
failing to compile with some features.
#17887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bevy_image
and bevy_gltf
failing to compile with some features.
#17887
Conversation
@@ -82,6 +82,7 @@ half = { version = "2.4.1" } | |||
[dev-dependencies] | |||
bevy_ecs = { path = "../bevy_ecs", version = "0.16.0-dev" } | |||
bevy_sprite = { path = "../bevy_sprite", version = "0.16.0-dev" } | |||
bevy_core_pipeline = { path = "../bevy_core_pipeline", version = "0.16.0-dev" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, this sucks. That's the wrong way for this dependency to flow. At least it's only a dev-dep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks alright to me, though the dds situation had me scratching my had a bit.
…18377) # Objective - #17887 introduced a circular dependency between bevy_image and bevy_core_pipeline - This makes it impossible to publish Bevy ## Solution - Remove the circular dependency, reintroduce the compilation failure - This failure shouldn't be an issue for users of Bevy, only for users of subcrates, and can be workaround - Proper fix should be done with #17891 - Limited compilation failure is better than publish failure
Fixes #17290.
Compilation errors before fix
cargo clippy --tests --all-features --package bevy_image
:cargo clippy --tests --all-features --package bevy_gltf
: