-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Add scenes similar to deferred_rendering
to 3d testbed
#18046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
simplyfied the test and added one more test to try and catch this issue with parallax #16679 (comment) |
…+prepass to forward
Screenshot of the |
Strongly in favor of this general direction. I'll probably defer to @mockersf on the exact testing details and the rendering folks on what should be shown though. |
@mockersf and @IceSentry will instruct me on how to filter this so that it is not run on EVERY PR |
This feels a bit too much on the different passes when we're not doing a lot of other things in 3d tests, and it increases the testbed_3d execution time from 20 seconds to 1m10. Maybe it's a better candidate to when we're able to select tests based on PR label |
not possible at the moment |
so it is |
triage: Has merge conflicts, still blocked |
Objective
The
deferred_rendering
example is frequently broken, adding it to the testbed will warn PRs that break it.Solution
Add scenes similar to
deferred_rendering
to 3d testbedTesting
cargo run --example testbed_3d --features="bevy_ci_testing"
Showcase
Screenshots for the new scenes

Forward
ForwardPrepass

Deferred

TODO