Skip to content

Add scenes similar to deferred_rendering to 3d testbed #18046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

hukasu
Copy link
Contributor

@hukasu hukasu commented Feb 26, 2025

Objective

The deferred_rendering example is frequently broken, adding it to the testbed will warn PRs that break it.

Solution

Add scenes similar to deferred_rendering to 3d testbed

Testing

cargo run --example testbed_3d --features="bevy_ci_testing"

Showcase

Screenshots for the new scenes
Forward
screenshot-Forward

ForwardPrepass
screenshot-ForwardPrepass

Deferred
screenshot-Deferred

TODO

  • Merge conflicts
  • Limit CI

@hukasu
Copy link
Contributor Author

hukasu commented Feb 26, 2025

simplyfied the test and added one more test to try and catch this issue with parallax #16679 (comment)

screenshot-RemovePrepass

@hukasu
Copy link
Contributor Author

hukasu commented Feb 26, 2025

Screenshot of the RemoveForwardPrepass scene on 5cc3f47, no particular reason for the choice of the commit, it was just an old commit that i knew that the parallax was broken

image

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Testing A change that impacts how we test Bevy or how users test their apps X-Contentious There are nontrivial implications that should be thought through S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 26, 2025
@alice-i-cecile alice-i-cecile added the A-Build-System Related to build systems or continuous integration label Feb 26, 2025
@alice-i-cecile
Copy link
Member

Strongly in favor of this general direction. I'll probably defer to @mockersf on the exact testing details and the rendering folks on what should be shown though.

@hukasu
Copy link
Contributor Author

hukasu commented Feb 26, 2025

@mockersf and @IceSentry will instruct me on how to filter this so that it is not run on EVERY PR

@mockersf
Copy link
Member

This feels a bit too much on the different passes when we're not doing a lot of other things in 3d tests, and it increases the testbed_3d execution time from 20 seconds to 1m10.

Maybe it's a better candidate to when we're able to select tests based on PR label

@mockersf
Copy link
Member

@mockersf and @IceSentry will instruct me on how to filter this so that it is not run on EVERY PR

not possible at the moment

@hukasu
Copy link
Contributor Author

hukasu commented Feb 26, 2025

so it is S-Blocked until then?

@alice-i-cecile alice-i-cecile added S-Blocked This cannot move forward until something else changes and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 26, 2025
@BenjaminBrienen
Copy link
Contributor

triage: Has merge conflicts, still blocked

@BenjaminBrienen BenjaminBrienen added the S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged label May 17, 2025
@BenjaminBrienen BenjaminBrienen removed the S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged label May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration A-Rendering Drawing game state to the screen C-Testing A change that impacts how we test Bevy or how users test their apps S-Blocked This cannot move forward until something else changes X-Contentious There are nontrivial implications that should be thought through
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants