Skip to content

Enable ambiguity detection in CI. #19566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Enable ambiguity detection in CI. #19566

wants to merge 1 commit into from

Conversation

andriyDev
Copy link
Contributor

Objective

  • Prevent system ambiguity from seeping in to the Render schedule.

Solution

  • Enable ambiguity detection for the Render schedule only for CI.

Testing

  • CI is the test!
  • I also checked if an intentional breakage would be caught, and it was! (testing to see if the ExtractSchedule would trigger ambiguity detection).

@andriyDev andriyDev force-pushed the ci-ambiguity branch 3 times, most recently from 7096c66 to 705c18f Compare June 10, 2025 07:28
@andriyDev andriyDev marked this pull request as ready for review June 10, 2025 07:28
@andriyDev andriyDev marked this pull request as draft June 10, 2025 07:39
@mockersf
Copy link
Member

this should work with #13950 instead of being another thing

@andriyDev
Copy link
Contributor Author

That is a lot simpler haha. Looks like there's a ton of system ambiguities in Render though. I'll work through them before setting this for review.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Testing A change that impacts how we test Bevy or how users test their apps labels Jun 11, 2025
@alice-i-cecile alice-i-cecile added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged D-Complex Quite challenging from either a design or technical perspective. Ask for help! X-Uncontroversial This work is generally agreed upon labels Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Testing A change that impacts how we test Bevy or how users test their apps D-Complex Quite challenging from either a design or technical perspective. Ask for help! S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged X-Uncontroversial This work is generally agreed upon
Projects
Rendering
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andriyDev @mockersf @alice-i-cecile