Skip to content

Make headerValue nullable #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Make headerValue nullable #51

merged 1 commit into from
Apr 15, 2020

Conversation

barryvdh
Copy link
Contributor

Default is null, which is incompatible with current string typehint

Default is `null`, which is incompatible with current `string` typehint
@barryvdh
Copy link
Contributor Author

Alternative would be to use '' as default.

@mpociot mpociot merged commit 637dc1e into beyondcode:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants