Skip to content

Fix tests #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Fix tests #5

merged 2 commits into from
Feb 25, 2022

Conversation

mokhosh
Copy link
Contributor

@mokhosh mokhosh commented Feb 26, 2021

Currently if you try to run the tests you get this error:

BeyondCode\LaravelMaskedDumper\Tests\DumperTest::it_can_dump_certain_tables_as_schema_only
Symfony\Component\Console\Exception\CommandNotFoundException: The command "db:dump" does not exist.

Because the actual command has been renamed from db:dump to db:masked-dump but the tests weren't updated.

After fixing that if you run the tests you get this one:

BeyondCode\LaravelMaskedDumper\Tests\DumperTest::it_can_replace_columns_with_faker_values
ArgumentCountError: Too few arguments to function BeyondCode\LaravelMaskedDumper\Tests\DumperTest::BeyondCode\LaravelMaskedDumper\Tests\{closure}(), 1 passed and exactly 2 expected

Because in it_can_replace_columns_with_faker_values we're receiving a $faker as dependency but we're never passing it in DumpSchema.php, and if we add that we become green.

@mokhosh mokhosh mentioned this pull request Feb 26, 2021
@mpociot mpociot merged commit 18bf8b8 into beyondcode:main Feb 25, 2022
@mpociot
Copy link
Member

mpociot commented Feb 25, 2022

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants