Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you try to run the tests you get this error:
Because the actual command has been renamed from
db:dump
todb:masked-dump
but the tests weren't updated.After fixing that if you run the tests you get this one:
Because in
it_can_replace_columns_with_faker_values
we're receiving a$faker
as dependency but we're never passing it inDumpSchema.php
, and if we add that we become green.