Skip to content
This repository was archived by the owner on Feb 7, 2024. It is now read-only.

[feature] Add restart command for WebSocket server #284

Merged
merged 1 commit into from
Aug 13, 2020
Merged

[feature] Add restart command for WebSocket server #284

merged 1 commit into from
Aug 13, 2020

Conversation

zaxxo
Copy link
Contributor

@zaxxo zaxxo commented Nov 6, 2019

This PR adds a console command for restart the WebSocket server.

For example if you deploy with Laravel Envoyer the server should be restarted because of a new version of the WebSocket package.

The command is inspired by the queue restart command.

Please note that this only works if the server is automatically restarted by Supervisor or something else as the server is only stopped with this command.

@dgoring
Copy link

dgoring commented Apr 28, 2020

Can this be re-considered as it would be very useful
and would bring it inline with the queue commands, which i use in my environment deployment script.

@N3rdP1um23
Copy link

I would love an update if possible! I have some projects with Forge and Envoyer and every new deployment breaks since Envoyer updates the deployment folder.

@slavarazum
Copy link

Yep, I just come to repository to search some solutions. It would be great to have an ability to restart server after each deploy.

@rennokki rennokki added postponed Will be postponed until further notice rebase Rebase is needed labels Aug 13, 2020
@rennokki
Copy link
Collaborator

@zaxxo I need a rebase on this PR.

@zaxxo
Copy link
Contributor Author

zaxxo commented Aug 13, 2020

@rennokki I have done a rebase.

@rennokki rennokki removed the rebase Rebase is needed label Aug 13, 2020
@rennokki
Copy link
Collaborator

@zaxxo Do you need this feature right away? I plan on focusing on the feature PRs after the other fixes PRs are resolved.

@zaxxo
Copy link
Contributor Author

zaxxo commented Aug 13, 2020

From my side, I don't need it right away. But I can't speak for the other participnats in this conversation.

In the meantime until the PR is merged, if anyone should need a restart command right away, you can use my package:

https://github.com/zaxxo/laravel-websockets-restart

@rennokki rennokki changed the title Add restart command for WebSocket server [feature] Add restart command for WebSocket server Aug 13, 2020
@rennokki rennokki merged commit d11daad into beyondcode:master Aug 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
postponed Will be postponed until further notice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants