This repository was archived by the owner on Feb 7, 2024. It is now read-only.
Fix presence channels double counting users #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know 2.x is under way but it would be nice to have 1.x in a working state and this is quite the bug 😄
What is happening?
Presence channels are double counting unique users because it's counting socket ID's.
How does Pusher handle this?
Pusher uses the
user_idproperty to uniquely count the users in a presence channel.Does this PR fix that?
Well, yes 😉
Okay, so why are the tests failing?
See: #528.
Would be great to see this released on 1.x.