Skip to content

[MAINT] Update code for assemble of contributors records and extend listing of referenced contributors #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 49 commits into
base: master
Choose a base branch
from

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Oct 20, 2024

@Remi-Gau Remi-Gau added the exclude-from-changelog This item will not feature in the automatically generated changelog label Oct 20, 2024
@Remi-Gau Remi-Gau changed the title update contributors [MAINT] update contributors Oct 20, 2024
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.65%. Comparing base (1f8487e) to head (c23f249).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1964   +/-   ##
=======================================
  Coverage   82.65%   82.65%           
=======================================
  Files          17       17           
  Lines        1534     1534           
=======================================
  Hits         1268     1268           
  Misses        266      266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Remi-Gau Remi-Gau marked this pull request as draft October 21, 2024 07:48
@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Oct 21, 2024

converting to draft:

  • check if some of the new contributors have a github account (I know some do)
  • need to add a few more contributors from some recently developed BIDS tools

@Remi-Gau
Copy link
Collaborator Author

TODO (but for future PRs):

  • add github usernames to contributors who have one
  • update affiliations (help to know where our contributors are from)
  • check people who have contributed to repos on BIDS and BIDS apps github organization, tools / converters repos...
  • check people mentioned on BIDS papers (that probably should be listed as contributors ?)

@Remi-Gau Remi-Gau marked this pull request as ready for review October 21, 2024 11:31
Copy link
Collaborator

@bendhouseart bendhouseart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "tools/add_contributors.py; git add -u; pre-commit run || :",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
Copy link
Contributor

@mguaypaq mguaypaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some edits for consistency.

"orcid": "0000-0003-2828-6031"
},
"mguaypaq": {
"affiliation": "Montreal, Quebec, Canada",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"affiliation": "Montreal, Quebec, Canada",
"affiliation": "NeuroPoly Lab, Polytechnique Montréal",

],
"login": "mguaypaq",
"name": "Mathieu Guay-Paquet",
"profile": "https://www.pointedset.ca/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"profile": "https://www.pointedset.ca/"
"profile": "https://github.com/mguaypaq"

- given-names: Mathieu
family-names: Guay-Paquet
website: https://www.pointedset.ca/
affiliation: Montreal, Quebec, Canada
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
affiliation: Montreal, Quebec, Canada
affiliation: NeuroPoly Lab, Polytechnique Montréal

</tr>
<tr>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/josator2"><img src="https://avatars.githubusercontent.com/u/9729281?v=4?s=100" width="100px;" alt="josator2"/><br /><sub><b>josator2</b></sub></a><br /><a href="https://github.com/bids-standard/bids-specification/commits?author=josator2" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><img src="https://avatars.githubusercontent.com/u/928742?v=4?s=100" width="100px;" alt="mathieu_guay-paquet"/><br /><sub><b>mathieu_guay-paquet</b></sub><br /><a href="https://github.com/bids-standard/bids-specification/commits?author=mguaypaq" title="Documentation">📖</a></td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<td align="center" valign="top" width="14.28%"><img src="https://avatars.githubusercontent.com/u/928742?v=4?s=100" width="100px;" alt="mathieu_guay-paquet"/><br /><sub><b>mathieu_guay-paquet</b></sub><br /><a href="https://github.com/bids-standard/bids-specification/commits?author=mguaypaq" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><img src="https://avatars.githubusercontent.com/u/928742?v=4?s=100" width="100px;" alt="Mathieu Guay-Paquet"/><br /><sub><b>Mathieu Guay-Paquet</b></sub><br /><a href="https://github.com/bids-standard/bids-specification/commits?author=mguaypaq" title="Documentation">📖</a></td>

| ezemikulan | 💻 |
| josator2 | 💻 |
| mathieu_guay-paquet | 📖 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| mathieu_guay-paquet | 📖 |
| Mathieu Guay-Paquet | 📖 |

"name": "Alyssa Dai",
"orcid": "0000-0003-0174-6800"
},
"amber_hopkins": {
Copy link

@amberrhopkins amberrhopkins May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CORRECTION

“amber_hopkins": {
"affiliation": “Department of Psychology, University of California Los Angeles, Los Angeles, California, United States",
"contributions": [
“doc"
],
"email": “[email protected]",
"github": "amberrhopkins",
"name": “Amber R. Hopkins",
"orcid": "0000-0002-8354-565X"
"publish_email": true
},

orcid: https://orcid.org/0000-0003-0174-6800
affiliation: origami lab, McGill university, Montreal, Québec, Canada
email: [email protected]
- given-names: Amber

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CORRECTION

  • given-names: Amber R.
    family-names: Hopkins
    orcid: https://orcid.org/0000-0002-8354-565X
    affiliation: Department of Psychology, University of California Los Angeles, Los Angeles, California, United States

"avatar_url": "https://avatars.githubusercontent.com/u/111446107?v=4",
"contributions": [
"code",
"doc"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"doc"
"doc",
"tool",
"example"

"code",
"doc"
],
"email": "[email protected]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"email": "pfarr@staff.uni-marburg.de",
"email": "juliakatharina.pfarr@gmail.com",

"blog": "https://github.com/julia-pfarr",
"contributions": [
"code",
"doc"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"doc"
"doc",
"tool",
"example"

family-names: Pfarr
website: https://github.com/julia-pfarr
orcid: https://orcid.org/0000-0003-1450-6005
email: [email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
email: pfarr@staff.uni-marburg.de
email: juliakatharina.pfarr@gmail.com
affiliation: McGill University

@@ -2207,6 +2614,35 @@
"orcid": "0000-0002-4685-0057",
"publish_email": false
},
"mtorabi59": {
"affiliation": "origami lab, McGill university, Montreal, Québec, Canada",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"affiliation": "origami lab, McGill university, Montreal, Québec, Canada",
"affiliation": "McGill University",

Copy link

@vhosouza vhosouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the amazing effort. My info requires some changes, which I made as suggestions in this PR.
Cheers!

Comment on lines +1644 to +1646
- given-names: Victor
family-names: Hugo Souza
email: [email protected]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- given-names: Victor
family-names: Hugo Souza
email: [email protected]
- given-names: Victor H.
family-names: Souza
website: https://vhosouza.github.io/
orcid: https://orcid.org/0000-0002-0254-4322
affiliation: Aalto University, Finland
email: [email protected]

Comment on lines +3493 to +3499
{
"contributions": [
"doc"
],
"login": "victor_hugo_souza",
"name": "Victor Hugo Souza"
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
"contributions": [
"doc"
],
"login": "victor_hugo_souza",
"name": "Victor Hugo Souza"
},
{
"contributions": [
"doc"
],
"login": "victor_h_souza",
"name": "Victor H. Souza"
},

Comment on lines +3624 to +3630
"victor_hugo_souza": {
"contributions": [
"doc"
],
"email": "[email protected]",
"name": "Victor Hugo Souza"
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"victor_hugo_souza": {
"contributions": [
"doc"
],
"email": "[email protected]",
"name": "Victor Hugo Souza"
},
"victor_h_souza": {
"affiliation": “Aalto University, Finland",
"blog": "https://vhosouza.github.io/",
"contributions": [
"doc"
],
"email": "[email protected]",
"github": "vhosouza",
"name": "Victor H. Souza",
"orcid": "0000-0002-0254-4322",
"publish_email": true
},

@@ -351,8 +389,10 @@ If you contributed to the BIDS ecosystem and your name is not listed, please add
| Ulrike Bingel | 📖 |
| Vanessa Sochat | 📖 |
| Vasudev Raguram | 💻🎨📖🔧 |
| Victor Hugo Souza | 📖 |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Victor Hugo Souza | 📖 |
| Victor H. Souza | 📖 |

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mekline - full name is Melissa Kline Struhl; all other details confirmed/okayed

Comment on lines +150 to +157
"po09i": {
"blog": "https://github.com/po09i",
"contributions": [
"doc"
],
"email": "[email protected]",
"name": "Alexandre D'Astous",
"orcid": "0000-0003-0381-7334"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good

@@ -182,6 +206,23 @@
"email": "[email protected]",
"name": "Alizee Wickenheiser"
},
"alyssadai": {
"affiliation": "origami lab, McGill university, Montreal, Québec, Canada",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"affiliation": "origami lab, McGill university, Montreal, Québec, Canada",
"affiliation": "McGill University",

"talk"
],
"email": "[email protected]",
"name": "Guiomar Galán",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "Guiomar Galán",
"name": "Guiomar Niso",

Thanks!

@@ -530,15 +642,20 @@ authors:
website: https://www.fil.ion.ucl.ac.uk/team/spm-team/
orcid: https://orcid.org/0000-0003-0077-7859
affiliation: University College London
- given-names: Guiomar
family-names: Galán
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
family-names: Galán
family-names: Niso

(it's a bit confussing with two names and two surnames :)
Thanks once more!

@@ -215,7 +227,9 @@ If you contributed to the BIDS ecosystem and your name is not listed, please add
| Joseph Woods | 📖 |
| Julia Guiomar Niso Galán | 🤔🎨🔍👀📋📝🔧🐛💻🔣✅💬📖💡📢 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Julia Guiomar Niso Galán | 🤔🎨🔍👀📋📝🔧🐛💻🔣✅💬📖💡📢 |
| Guiomar Niso | 🤔🎨🔍👀📋📝🔧🐛💻🔣✅💬📖💡📢 |

I shorten it here, so it's easier and matches what's on the other docs.
Thnaks for working on this, it's a challenging but very important thing to have a curated list of contributors :)

@@ -1116,21 +1289,26 @@
"contributions": [
"doc"
],
"email": "[email protected]",
"name": "Giuseppe Gallitto",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the github name is "gallg". The Orcid number is correct. Contributions is BEP035, I don't know it that should be flagged as doc, ideas or both

"bids-maintenance": {
"bio": "Doing work here-and-there for @bids-standard",
"blog": "https://bids.neuroimaging.io/",
"name": "BIDS Maintenance User"
},
"balint_kincses": {
Copy link

@gallg gallg May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github name: "kincsesbalint". Orcid: 0000-0002-0478-6384. Orcid number can also be added to CITATION.cff

@@ -1063,6 +1225,7 @@
"contributions": [
"doc"
],
"email": "[email protected]",
Copy link

@GiacomoBert GiacomoBert May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“GiacomoBert": { "affiliation": “Berenson-Allen Center for Noninvasive Brain Stimulation, Beth Israel Deaconess Medical Center and Harvard Medical School, Boston, MA, USA, Department of Neurology, Harvard Medical School, Boston, MA, USA", "contributions": [ “doc" ], "email": “[[email protected]](mailto:[email protected])", "github": "GiacomoBert", "name": “Giacomo Bertazzoli", "orcid": "0000-0003-1624-2576" "publish_email": true },

@@ -2923,6 +3504,15 @@
"orcid": "0000-0001-5153-1424",
"publish_email": true
},
"til_ole_bergmann": {
"affiliation": "ohannes-Gutenberg University Medical Center, Mainz Germany",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

affiliation is

Johannes-Gutenberg University Medical Center, Mainz Germany

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"affiliation": "ohannes-Gutenberg University Medical Center, Mainz Germany",
"affiliation": "Johannes-Gutenberg University Medical Center, Mainz Germany",

"email": "[email protected]",
"name": "Til Ole Bergmann",
"orcid": "0000-0002-2282-6618"
},
"dickscheid": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also Friederike Breuer should be added as

"friederike_breuer": { "affiliation": "Johannes-Gutenberg University Medical Center, Mainz Germany", "contributions": [ "doc" ], "email": "[email protected]", "name": "Friederike Breuer", },

@melanieganz
Copy link
Contributor

Thank you so much for all your efforts! I just updated my e-mail to the university one to match the affiliation.

@yarikoptic yarikoptic self-assigned this Jun 11, 2025
@yarikoptic yarikoptic added the copenhagen For discussion in Copenhagen label Jun 11, 2025
],
"email": "[email protected]",
"github": "djarecka",
"name": "Dorota Jarecka"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "Dorota Jarecka"
"name": "Dorota Jarecka",
"orcid": "0000-0001-8282-2988"

family-names: Jarecka
website: https://www.linkedin.com/in/djarecka
affiliation: MIT, Cambridge, USA
email: [email protected]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
email: [email protected]
email: [email protected]
orcid: https://orcid.org/0000-0001-8282-2988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
copenhagen For discussion in Copenhagen
Projects
None yet
Development

Successfully merging this pull request may close these issues.