-
Notifications
You must be signed in to change notification settings - Fork 182
[MAINT] Update code for assemble of contributors records and extend listing of referenced contributors #1964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1964 +/- ##
=======================================
Coverage 82.65% 82.65%
=======================================
Files 17 17
Lines 1534 1534
=======================================
Hits 1268 1268
Misses 266 266 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b999731
to
ee61888
Compare
3626e29
to
e10d2d1
Compare
converting to draft:
|
TODO (but for future PRs):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…ing duplicates etc
=== Do not change lines below === { "chain": [], "cmd": "tools/add_contributors.py; git add -u; pre-commit run || :", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some edits for consistency.
"orcid": "0000-0003-2828-6031" | ||
}, | ||
"mguaypaq": { | ||
"affiliation": "Montreal, Quebec, Canada", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"affiliation": "Montreal, Quebec, Canada", | |
"affiliation": "NeuroPoly Lab, Polytechnique Montréal", |
], | ||
"login": "mguaypaq", | ||
"name": "Mathieu Guay-Paquet", | ||
"profile": "https://www.pointedset.ca/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"profile": "https://www.pointedset.ca/" | |
"profile": "https://github.com/mguaypaq" |
- given-names: Mathieu | ||
family-names: Guay-Paquet | ||
website: https://www.pointedset.ca/ | ||
affiliation: Montreal, Quebec, Canada |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
affiliation: Montreal, Quebec, Canada | |
affiliation: NeuroPoly Lab, Polytechnique Montréal |
</tr> | ||
<tr> | ||
<td align="center" valign="top" width="14.28%"><a href="https://github.com/josator2"><img src="https://avatars.githubusercontent.com/u/9729281?v=4?s=100" width="100px;" alt="josator2"/><br /><sub><b>josator2</b></sub></a><br /><a href="https://github.com/bids-standard/bids-specification/commits?author=josator2" title="Code">💻</a></td> | ||
<td align="center" valign="top" width="14.28%"><img src="https://avatars.githubusercontent.com/u/928742?v=4?s=100" width="100px;" alt="mathieu_guay-paquet"/><br /><sub><b>mathieu_guay-paquet</b></sub><br /><a href="https://github.com/bids-standard/bids-specification/commits?author=mguaypaq" title="Documentation">📖</a></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<td align="center" valign="top" width="14.28%"><img src="https://avatars.githubusercontent.com/u/928742?v=4?s=100" width="100px;" alt="mathieu_guay-paquet"/><br /><sub><b>mathieu_guay-paquet</b></sub><br /><a href="https://github.com/bids-standard/bids-specification/commits?author=mguaypaq" title="Documentation">📖</a></td> | |
<td align="center" valign="top" width="14.28%"><img src="https://avatars.githubusercontent.com/u/928742?v=4?s=100" width="100px;" alt="Mathieu Guay-Paquet"/><br /><sub><b>Mathieu Guay-Paquet</b></sub><br /><a href="https://github.com/bids-standard/bids-specification/commits?author=mguaypaq" title="Documentation">📖</a></td> |
| ezemikulan | 💻 | | ||
| josator2 | 💻 | | ||
| mathieu_guay-paquet | 📖 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| mathieu_guay-paquet | 📖 | | |
| Mathieu Guay-Paquet | 📖 | |
"name": "Alyssa Dai", | ||
"orcid": "0000-0003-0174-6800" | ||
}, | ||
"amber_hopkins": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CORRECTION
“amber_hopkins": {
"affiliation": “Department of Psychology, University of California Los Angeles, Los Angeles, California, United States",
"contributions": [
“doc"
],
"email": “[email protected]",
"github": "amberrhopkins",
"name": “Amber R. Hopkins",
"orcid": "0000-0002-8354-565X"
"publish_email": true
},
orcid: https://orcid.org/0000-0003-0174-6800 | ||
affiliation: origami lab, McGill university, Montreal, Québec, Canada | ||
email: [email protected] | ||
- given-names: Amber |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CORRECTION
- given-names: Amber R.
family-names: Hopkins
orcid: https://orcid.org/0000-0002-8354-565X
affiliation: Department of Psychology, University of California Los Angeles, Los Angeles, California, United States
"avatar_url": "https://avatars.githubusercontent.com/u/111446107?v=4", | ||
"contributions": [ | ||
"code", | ||
"doc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"doc" | |
"doc", | |
"tool", | |
"example" |
"code", | ||
"doc" | ||
], | ||
"email": "[email protected]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"email": "pfarr@staff.uni-marburg.de", | |
"email": "juliakatharina.pfarr@gmail.com", |
"blog": "https://github.com/julia-pfarr", | ||
"contributions": [ | ||
"code", | ||
"doc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"doc" | |
"doc", | |
"tool", | |
"example" |
family-names: Pfarr | ||
website: https://github.com/julia-pfarr | ||
orcid: https://orcid.org/0000-0003-1450-6005 | ||
email: [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
email: pfarr@staff.uni-marburg.de | |
email: juliakatharina.pfarr@gmail.com | |
affiliation: McGill University |
@@ -2207,6 +2614,35 @@ | |||
"orcid": "0000-0002-4685-0057", | |||
"publish_email": false | |||
}, | |||
"mtorabi59": { | |||
"affiliation": "origami lab, McGill university, Montreal, Québec, Canada", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"affiliation": "origami lab, McGill university, Montreal, Québec, Canada", | |
"affiliation": "McGill University", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the amazing effort. My info requires some changes, which I made as suggestions in this PR.
Cheers!
- given-names: Victor | ||
family-names: Hugo Souza | ||
email: [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- given-names: Victor | |
family-names: Hugo Souza | |
email: [email protected] | |
- given-names: Victor H. | |
family-names: Souza | |
website: https://vhosouza.github.io/ | |
orcid: https://orcid.org/0000-0002-0254-4322 | |
affiliation: Aalto University, Finland | |
email: [email protected] |
{ | ||
"contributions": [ | ||
"doc" | ||
], | ||
"login": "victor_hugo_souza", | ||
"name": "Victor Hugo Souza" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ | |
"contributions": [ | |
"doc" | |
], | |
"login": "victor_hugo_souza", | |
"name": "Victor Hugo Souza" | |
}, | |
{ | |
"contributions": [ | |
"doc" | |
], | |
"login": "victor_h_souza", | |
"name": "Victor H. Souza" | |
}, |
"victor_hugo_souza": { | ||
"contributions": [ | ||
"doc" | ||
], | ||
"email": "[email protected]", | ||
"name": "Victor Hugo Souza" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"victor_hugo_souza": { | |
"contributions": [ | |
"doc" | |
], | |
"email": "[email protected]", | |
"name": "Victor Hugo Souza" | |
}, | |
"victor_h_souza": { | |
"affiliation": “Aalto University, Finland", | |
"blog": "https://vhosouza.github.io/", | |
"contributions": [ | |
"doc" | |
], | |
"email": "[email protected]", | |
"github": "vhosouza", | |
"name": "Victor H. Souza", | |
"orcid": "0000-0002-0254-4322", | |
"publish_email": true | |
}, |
@@ -351,8 +389,10 @@ If you contributed to the BIDS ecosystem and your name is not listed, please add | |||
| Ulrike Bingel | 📖 | | |||
| Vanessa Sochat | 📖 | | |||
| Vasudev Raguram | 💻🎨📖🔧 | | |||
| Victor Hugo Souza | 📖 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Victor Hugo Souza | 📖 | | |
| Victor H. Souza | 📖 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mekline - full name is Melissa Kline Struhl; all other details confirmed/okayed
"po09i": { | ||
"blog": "https://github.com/po09i", | ||
"contributions": [ | ||
"doc" | ||
], | ||
"email": "[email protected]", | ||
"name": "Alexandre D'Astous", | ||
"orcid": "0000-0003-0381-7334" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good
@@ -182,6 +206,23 @@ | |||
"email": "[email protected]", | |||
"name": "Alizee Wickenheiser" | |||
}, | |||
"alyssadai": { | |||
"affiliation": "origami lab, McGill university, Montreal, Québec, Canada", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"affiliation": "origami lab, McGill university, Montreal, Québec, Canada", | |
"affiliation": "McGill University", |
"talk" | ||
], | ||
"email": "[email protected]", | ||
"name": "Guiomar Galán", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"name": "Guiomar Galán", | |
"name": "Guiomar Niso", |
Thanks!
@@ -530,15 +642,20 @@ authors: | |||
website: https://www.fil.ion.ucl.ac.uk/team/spm-team/ | |||
orcid: https://orcid.org/0000-0003-0077-7859 | |||
affiliation: University College London | |||
- given-names: Guiomar | |||
family-names: Galán |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
family-names: Galán | |
family-names: Niso |
(it's a bit confussing with two names and two surnames :)
Thanks once more!
@@ -215,7 +227,9 @@ If you contributed to the BIDS ecosystem and your name is not listed, please add | |||
| Joseph Woods | 📖 | | |||
| Julia Guiomar Niso Galán | 🤔🎨🔍👀📋📝🔧🐛💻🔣✅💬📖💡📢 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Julia Guiomar Niso Galán | 🤔🎨🔍👀📋📝🔧🐛💻🔣✅💬📖💡📢 | | |
| Guiomar Niso | 🤔🎨🔍👀📋📝🔧🐛💻🔣✅💬📖💡📢 | |
I shorten it here, so it's easier and matches what's on the other docs.
Thnaks for working on this, it's a challenging but very important thing to have a curated list of contributors :)
@@ -1116,21 +1289,26 @@ | |||
"contributions": [ | |||
"doc" | |||
], | |||
"email": "[email protected]", | |||
"name": "Giuseppe Gallitto", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the github name is "gallg". The Orcid number is correct. Contributions is BEP035, I don't know it that should be flagged as doc, ideas or both
"bids-maintenance": { | ||
"bio": "Doing work here-and-there for @bids-standard", | ||
"blog": "https://bids.neuroimaging.io/", | ||
"name": "BIDS Maintenance User" | ||
}, | ||
"balint_kincses": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github name: "kincsesbalint". Orcid: 0000-0002-0478-6384. Orcid number can also be added to CITATION.cff
@@ -1063,6 +1225,7 @@ | |||
"contributions": [ | |||
"doc" | |||
], | |||
"email": "[email protected]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“GiacomoBert": { "affiliation": “Berenson-Allen Center for Noninvasive Brain Stimulation, Beth Israel Deaconess Medical Center and Harvard Medical School, Boston, MA, USA, Department of Neurology, Harvard Medical School, Boston, MA, USA", "contributions": [ “doc" ], "email": “[[email protected]](mailto:[email protected])", "github": "GiacomoBert", "name": “Giacomo Bertazzoli", "orcid": "0000-0003-1624-2576" "publish_email": true },
@@ -2923,6 +3504,15 @@ | |||
"orcid": "0000-0001-5153-1424", | |||
"publish_email": true | |||
}, | |||
"til_ole_bergmann": { | |||
"affiliation": "ohannes-Gutenberg University Medical Center, Mainz Germany", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
affiliation is
Johannes-Gutenberg University Medical Center, Mainz Germany
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"affiliation": "ohannes-Gutenberg University Medical Center, Mainz Germany", | |
"affiliation": "Johannes-Gutenberg University Medical Center, Mainz Germany", |
"email": "[email protected]", | ||
"name": "Til Ole Bergmann", | ||
"orcid": "0000-0002-2282-6618" | ||
}, | ||
"dickscheid": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also Friederike Breuer should be added as
"friederike_breuer": { "affiliation": "Johannes-Gutenberg University Medical Center, Mainz Germany", "contributions": [ "doc" ], "email": "[email protected]", "name": "Friederike Breuer", },
Thank you so much for all your efforts! I just updated my e-mail to the university one to match the affiliation. |
], | ||
"email": "[email protected]", | ||
"github": "djarecka", | ||
"name": "Dorota Jarecka" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"name": "Dorota Jarecka" | |
"name": "Dorota Jarecka", | |
"orcid": "0000-0001-8282-2988" |
family-names: Jarecka | ||
website: https://www.linkedin.com/in/djarecka | ||
affiliation: MIT, Cambridge, USA | ||
email: [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
email: [email protected] | |
email: [email protected] | |
orcid: https://orcid.org/0000-0001-8282-2988 |
Uh oh!
There was an error while loading. Please reload this page.